Re-organized code and a lot of other stuff.

[FiloSottile]

Here is my recent work on youtube-dl. I've been really bold, but I tried to keep it elegant, in line with the philosophy of this project and tested.
Let's enumerate the changes:

• [ #193 ] I've split the code in a python package, that is a bunch of files inside the youtube_dl directory. The package gets compiled by make compile into an executable zipfile. The zipfile is prepended with a shebang so that it remains executable on Linux.
  • This is a really stable and portable way to distribute the code: it is a single file; it behaves exactly as a script (supported on Python >= 2.6); the tracebacks are readable; it is compatible with all the platforms I was able to test on.
  • Please read that StackOverflow discussion and the relevant Python bug as a reference.
• [ #153 ] I've written build_exe.py and wine-py2exe.sh that creates a Windows EXE automatically using WINE that is able to update itself.
  • When executed, wine-py2exe.sh creates a WINEPREFIX in wine-py2exe/, installs Python and py2exe inside it and the creates the exe using the setup.py passed as argument (build_exe.py).
  • That required a lot of hacks: the WINE support is achieved patching the PE headers of the template executables of py2exe; the -U writes a bat file and executes it before dying.
• I dropped Python 2.5 support. Because:
  • It doesn't support a lot of things, that block the development of some ideas and require a lot of fallback code.
  • It is a 6 years old release, without official binary/documentation releases since 2008 and "under the current release policy, no security issues in Python 2.5 will be fixed anymore". It is now a really bad thing to run 2.5 and it should be deprecated everywhere.
• [ #296 ] Moved increment_downloads and process_info calls from IEs to FD.download; a small step towards importability (#217)

That pull request includes the following branches, so refer to them for what the changes are:

• #316 - [ @FiloSottile ] added support for HTTP redirects. Closes #315
• #321 - [ @FiloSottile ] Handle next_url redirections (and whitespaces stripping)
• #329 - [ @FiloSottile ] So long lxml, and thanks for all the fish

This is a fast-forward ready merge from the current upstream.

[phihag]

These changes are too good to be left out. Merged all of them. I might change some details though before releasing a new version.

[mirabilos]

Excuse me, but, what?!

This breaks my Python, which chokes on the zip binary junk.

[Tailszefox]

Which version of Python are you using? This new format works perfectly with Python >=2.6 but is unsupported by other versions. If you have a lower version and can't upgrade, try giving a look at the FAQ which outlines a way to make it work with lower versions.

[FiloSottile]

If you are using cPython 2.5, well, you have a bigger problem than this. Otherwise, it will work fine. Also, this is the common way to ship Python packages, the zipfile is only a commodity, you can grab the package folder and run that.

[mirabilos]

Ah okay. Ouch. Looks like I’m going to have to port a newer Python then… the latest of 2.7 would be best I suppose.

[FiloSottile]

Yeah, that would be the best. You can actually get youtube-dl working anyway, but using 2.5 today is a security risk. ## Filippo Valsorda Inviato con Sparrow (http://www.sparrowmailapp.com/?sig) Il giorno mercoledì 31 ottobre 2012, alle ore 14:34, mirabilos ha scritto:

…

Ah okay. Ouch. Looks like I’m going to have to port a newer Python then… the latest of 2.7 would be best I suppose. — Reply to this email directly or view it on GitHub (d77c3df#commitcomment-2080512).

[mirabilos]

Okay, thanks anyway. It used to work well. I wonder how much I have to fix BitTorrent 3.4 to work with Python 2.7 though… bumping it from 2.3 to 2.5 was “fun” already. But that’s not your construction site. Thanks for the heads-up (I thought I had received a garbage file until I found this after some discussion on Debian) and your work on this program.