fixed build issues of debian/ubuntu #24

Merged
merged 5 commits into from Mar 20, 2013

Conversation

Projects
None yet
2 participants
Contributor

jianingy commented Mar 20, 2013

First, I've added a control.template for making debian package.

In addition, I've changed architecture choosing rule. The logic of my patch is that if there is no 'arch' specified in package's index.yaml or system-wide default.yaml it will set self->info->data->{arch} to the architecture of current box using 'uname -m'.

Moreover, though x86_64 debian reports its arch 'x86_64', debian is actually not comfortable with this string. So, I've added some code to replace 'x86_64' with 'amd64' which is debian's flavor.

I've tested this patch on my ubuntu and CentOS 6. it works and it seems not to break other things.

Thanks very much.

Contributor

nmeyerhans commented Mar 20, 2013

Instead of "uname -m", why not "dpkg --print-architecture". The latter will return the architecture in the "official" debian format, e.g. amd64.

Contributor

jianingy commented Mar 20, 2013

Well, that's my ignorant to debian system :P. I'll try use 'arch' command to get arch string on Redhat/CentOS and 'dpkg --print-architecture' on debian. What do you think about it?

@nmeyerhans nmeyerhans added a commit that referenced this pull request Mar 20, 2013

@nmeyerhans nmeyerhans Merge pull request #24 from jianingy/debian-issues
fixed build issues of debian/ubuntu
78f83d5

@nmeyerhans nmeyerhans merged commit 78f83d5 into ytoolshed:master Mar 20, 2013

jianingy deleted the jianingy:debian-issues branch May 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment