New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Official Image on Docker Hub #297

Closed
waja opened this Issue Jan 29, 2016 · 18 comments

Comments

Projects
None yet
4 participants
@waja
Copy link

waja commented Jan 29, 2016

I stumbled upon an Image on Docker Hub which looks like it's an official one. Said that, do you think it would be a good idea to have one?
As the build can be automated there should not be much work to keep it updated, after the initial setup, I guess.

@ytti

This comment has been minimized.

Copy link
Owner

ytti commented Jan 29, 2016

Yeah it's official. If someone wants to automate it, I'm sure @nopedial is happy to share credentials.

@mikebryant

This comment has been minimized.

Copy link
Collaborator

mikebryant commented Feb 1, 2016

I'd be happy to set up the configuration for this

@nopedial

This comment has been minimized.

Copy link
Collaborator

nopedial commented Feb 4, 2016

Happy to add you guys as collaborators, let me know your dockerhub logins.

@mikebryant

This comment has been minimized.

Copy link
Collaborator

mikebryant commented Feb 4, 2016

@nopedial mikebryant

@nopedial

This comment has been minimized.

Copy link
Collaborator

nopedial commented Feb 5, 2016

@mikebryant done - let me know when you make progress so I can test

@mikebryant

This comment has been minimized.

Copy link
Collaborator

mikebryant commented Feb 6, 2016

@nopedial When I log in to dockerhub, I don't see anything different - the oxidized organisation doesn't give me any sort of access to change things.

@nopedial

This comment has been minimized.

Copy link
Collaborator

nopedial commented Feb 6, 2016

@mikebryant you are definitely added as collaborators to the repo - you should be able to push to the repo but not much else - there is no organization and teams for oxidized, just the repo.

@nopedial

This comment has been minimized.

Copy link
Collaborator

nopedial commented Feb 6, 2016

I've converted the user to an organization and added you as owner - let me know if you are able to change things now.

@mikebryant

This comment has been minimized.

Copy link
Collaborator

mikebryant commented Feb 6, 2016

@nopedial Awesome, that's working for me now.

@ytti Would I be able to get collaborator access to the ytti/oxidized github repo?
Need to add a webhook to make the automated builds work, and dockerhub doesn't seem to want to let me make an automated build for a repo I'm not a collaborator on

@ytti

This comment has been minimized.

Copy link
Owner

ytti commented Feb 6, 2016

@mikebryant no problem

@mikebryant

This comment has been minimized.

Copy link
Collaborator

mikebryant commented Mar 3, 2016

I believe this is now working

@waja

This comment has been minimized.

Copy link
Author

waja commented Mar 3, 2016

Is this also working for tags or just for master?

@mikebryant

This comment has been minimized.

Copy link
Collaborator

mikebryant commented Mar 4, 2016

Only master - currently the Dockerfile uses the gem version rather than the repository contents, so tagged builds wouldn't necessarily reflect the right version.

@nopedial

This comment has been minimized.

Copy link
Collaborator

nopedial commented Mar 4, 2016

@mikebryant I feel using the repository content might make more sense, what are your feelings on this?

@mikebryant

This comment has been minimized.

Copy link
Collaborator

mikebryant commented Mar 4, 2016

I'd be happy with that.

My only concerns/thoughs are about oxidized-web - are we happy for the docker build of oxidized to just pull in the latest version at the time of said build?

@nopedial

This comment has been minimized.

Copy link
Collaborator

nopedial commented Mar 4, 2016

I think it would be fine, any concerns from your side @ytti ?

@ytti

This comment has been minimized.

Copy link
Owner

ytti commented Mar 4, 2016

no concerns here

@ytti

This comment has been minimized.

Copy link
Owner

ytti commented May 5, 2016

I think this is done deal. Reopen if issues.

@ytti ytti closed this May 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment