Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web API /next returns status 500 if node is waiting to poll #3163

Open
ktims opened this issue May 14, 2024 · 1 comment
Open

Web API /next returns status 500 if node is waiting to poll #3163

ktims opened this issue May 14, 2024 · 1 comment

Comments

@ktims
Copy link
Contributor

ktims commented May 14, 2024

When calling /next/<node> from an external service to notify Oxidized of config changes, the API sometimes responds with 500 Internal Server Error, particularly at startup.

Apparently this is due to the underlying next implementation only searching the list of nodes that aren't currently 'running' a poll job. If the node is currently 'running', then it will not be found, and this will raise which is not caught, not return nil/false which would be.

return unless waiting.find_node_index(node)

@github-actions github-actions bot added the Stale label Aug 13, 2024
@Haeki Haeki mentioned this issue Aug 28, 2024
4 tasks
@Haeki
Copy link

Haeki commented Aug 28, 2024

I noticed the same problem as well.
I implemented a fix that works in our oxidized installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants