Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneos system hardware and product-info-area commands #1919

Merged
merged 1 commit into from Oct 13, 2019

Conversation

raunz
Copy link
Contributor

@raunz raunz commented Sep 30, 2019

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Added show system hardware and show product-info-area to OneAccess model.
Comments now contain device description and serial number information.

Perhaps it's reasonable to cut out "! +------------------------------+---------------------------------+" lines to reduce dumb formatting output?...

Live example:

!  HARDWARE DESCRIPTION
!
!   Device   : One20d
!   CPU      : MPC8323 PowerQUICC II Pro
!
!  Bus Freq : 133MHz   QE Freq : 200MHz   Core Freq : 266MHz
!  Ram size :  64Mo    Flash size : 512Ko   Extended Flash size :  32Mo
!  Ram disk :   1Mo    Flash disk :  32Mo  (Extended)
!
!  Local : x Uplink : x ISDN :
!
!  Local  : FAST ETHERNET + SWITCH ETHERNET / 4 ports
!  Uplink : G.SHDSL.bis / 2 pairs
!
!
! +----------------------------------------------------------------+
! |                       Product Info Area                        |
! +------------------------------+---------------------------------+
! | Key                          | Value                           |
! +------------------------------+---------------------------------+
! | mac0                         | 00:12:EF:61:75:07               |
! +------------------------------+---------------------------------+
! | mac1                         | 00:12:EF:65:75:07               |
! +------------------------------+---------------------------------+
! | mac2                         | 00:12:EF:69:75:07               |
! +------------------------------+---------------------------------+
! | mac3                         | 00:12:EF:6D:75:07               |
! +------------------------------+---------------------------------+
! | mac4                         | 00:12:EF:71:75:07               |
! +------------------------------+---------------------------------+
! | mac5                         | 00:12:EF:75:75:07               |
! +------------------------------+---------------------------------+
! | mac6                         | 00:12:EF:79:75:07               |
! +------------------------------+---------------------------------+
! | mac7                         | 00:12:EF:7D:75:07               |
! +------------------------------+---------------------------------+
! | mac8                         | 00:00:00:00:00:00               |
! +------------------------------+---------------------------------+
! | mac9                         | 00:00:00:00:00:00               |
! +------------------------------+---------------------------------+
! | mac10                        | 00:00:00:00:00:00               |
! +------------------------------+---------------------------------+
! | mac11                        | 00:00:00:00:00:00               |
! +------------------------------+---------------------------------+
! | mac12                        | 00:00:00:00:00:00               |
! +------------------------------+---------------------------------+
! | mac13                        | 00:00:00:00:00:00               |
! +------------------------------+---------------------------------+
! | mac14                        | 00:00:00:00:00:00               |
! +------------------------------+---------------------------------+
! | mac15                        | 00:00:00:00:00:00               |
! +------------------------------+---------------------------------+
! | Manufacturing File Reference | 1020 00 N 4024504W00 CB         |
! +------------------------------+---------------------------------+
! | Motherboard Type             | MB20SDPE0BNW                    |
! +------------------------------+---------------------------------+
! | Manufacturing Location       | TOAB                            |
! +------------------------------+---------------------------------+
! | Manufacturing Date           | 18/03/2011                      |
! +------------------------------+---------------------------------+
! | Serial Number                | T1111004504025810               |
! +------------------------------+---------------------------------+

@wk
Copy link
Contributor

wk commented Oct 13, 2019

Keeping the output as close as possible to the original is typically desirable, as this allows users to run unmodified scripts / tools against collected data as they would on equipment output.

This looks good, and none of the data in the output appears volatile. Pulling this in.

@wk wk merged commit fa52a97 into ytti:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants