update prompt for aosw #3233
update prompt for aosw #3233
Conversation
|
Thank you for the submission. The proposed prompt is not backward compatible. I'm working on it. |
|
Maybe we should make test file, that specifically loads prompt from each model, so we could put prompt unit tests in single file? It seems one of the most fragile part of models, for people who don't use exec mode, as people regularly make very poor prompts to both direction, too liberal and getting partial configs and too specific not working outside specific environemnt. Controlling this seems very hard, without unit test. And unlike rest of the model, it seems quite low hanging fruit to target in testing. |
|
The unit test is already written, will commit soon ;-) |
That was of course unplanned. Since we only use devices with AOS 8, I did not notice this when testing. |
- Create an unit test for the aosw prompt - Update credits in Changelog - Update prompt regexp to match virtual controllers on AP-515 - Resolve warnings about ambiguity between regexp and two divisions by wrapping the regexp in parentheses.
|
@mabezi - could you test the PR if it works in your setup? |
|
Works for me. Using ArubaMM-VA with AOS 8.10 and Aruba7210 with AOS 8.10 |
|
Perfect, thank you for the quick test. |
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
The aosw template no longer works with newer versions of AOS 8.
With this prompt it should work again. (At least on our devices with AOS 8 it now works).
Should close #3151