support option timeout #115

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants
@zyfdegh
Contributor

zyfdegh commented Aug 14, 2016

It's better to add "timeout" option #78

@yudai

This comment has been minimized.

Show comment
Hide comment
@yudai

yudai Jan 7, 2017

Owner

Hi, sorry for the late reply.
Could you rebase the commit so that I can merge this PR?

Thanks!

Owner

yudai commented Jan 7, 2017

Hi, sorry for the late reply.
Could you rebase the commit so that I can merge this PR?

Thanks!

@zyfdegh

This comment has been minimized.

Show comment
Hide comment
@zyfdegh

zyfdegh Jan 8, 2017

Contributor

It's not a good idea to import zyfdegh/boomer, because I use for loop to count down time, it's not accurate in fact. Anyone could contribute to fix this(using channel or time.Ticker) ?

Contributor

zyfdegh commented Jan 8, 2017

It's not a good idea to import zyfdegh/boomer, because I use for loop to count down time, it's not accurate in fact. Anyone could contribute to fix this(using channel or time.Ticker) ?

@yudai

This comment has been minimized.

Show comment
Hide comment
@yudai

yudai Jan 9, 2017

Owner

I just pushed a commit that adds timeout support.
Thanks for the feed back.

Owner

yudai commented Jan 9, 2017

I just pushed a commit that adds timeout support.
Thanks for the feed back.

@yudai yudai closed this Jan 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment