Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support option timeout #115

Closed
wants to merge 6 commits into from
Closed

support option timeout #115

wants to merge 6 commits into from

Conversation

@zyfdegh
Copy link
Contributor

zyfdegh commented Aug 14, 2016

It's better to add "timeout" option #78

yzhang3 and others added 5 commits Aug 10, 2016
yzhang3
yzhang3
yzhang3
@yudai
Copy link
Owner

yudai commented Jan 7, 2017

Hi, sorry for the late reply.
Could you rebase the commit so that I can merge this PR?

Thanks!

@zyfdegh
Copy link
Contributor Author

zyfdegh commented Jan 8, 2017

It's not a good idea to import zyfdegh/boomer, because I use for loop to count down time, it's not accurate in fact. Anyone could contribute to fix this(using channel or time.Ticker) ?

@yudai
Copy link
Owner

yudai commented Jan 9, 2017

I just pushed a commit that adds timeout support.
Thanks for the feed back.

@yudai yudai closed this Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.