New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docdb: [PITR-YSQL] PITR not working with Drop Index; table not getting restored pre-index drop #10256
Projects
Comments
DB Version:
then I created one more with different name and output is
|
sanketkedia
changed the title
PITR: PITR not working with Drop Index; table not getting restored pre-index drop
docdb: [PITR-YSQL] PITR not working with Drop Index; table not getting restored pre-index drop
Oct 17, 2021
sanketkedia
added a commit
that referenced
this issue
Nov 11, 2021
…ables Summary: Our current logic of iterating over the pg_catalog and computing the difference between the state of the tables at present v/s at the restoration time is incorrect. In particular, it skips over the actual row of the table on encountering a tombstoned entry for the same row irrespective of when they were written. Fix is to not skip entries whose subkeys are prefixes of one another. Also, if we don't skip them then we need to properly handle tombstoned entries and their effects on other entries. For instance an entry could be tombstoned after inserting and while computing the venn diagram of differences we should take into account that this entry has been deleted. In terms of time taken for restores, there's not much increase in restore time after this change. It is still the same number of seconds approximately. Test Plan: Jenkins Reviewers: bogdan, sergei Reviewed By: sergei Subscribers: ybase Differential Revision: https://phabricator.dev.yugabyte.com/D13705
sanketkedia
added a commit
that referenced
this issue
Nov 22, 2021
…ystem Catalog tables Summary: Our current logic of iterating over the pg_catalog and computing the difference between the state of the tables at present v/s at the restoration time is incorrect. In particular, it skips over the actual row of the table on encountering a tombstoned entry for the same row irrespective of when they were written. Fix is to not skip entries whose subkeys are prefixes of one another. Also, if we don't skip them then we need to properly handle tombstoned entries and their effects on other entries. For instance an entry could be tombstoned after inserting and while computing the venn diagram of differences we should take into account that this entry has been deleted. In terms of time taken for restores, there's not much increase in restore time after this change. It is still the same number of seconds approximately. Original commit: D13705 / ac351ab Test Plan: Jenkins: rebase: 2.8 Reviewers: bogdan, sergei Reviewed By: sergei Subscribers: ybase Differential Revision: https://phabricator.dev.yugabyte.com/D13982
Validated in 2.11.1.0-b300 and works as expected, closing this issue @sanketkedia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed in builds: 2.9.1.0 build 132, 2.8.0.0-b5
Expected result:
The dropped index should be restored and the index should be present in the table.
Actual Result:
The index continues to remain dropped even after the PITR making PITR ineffective with the drop index command.
The text was updated successfully, but these errors were encountered: