Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Avoid unnecessary index update preparation #1232

Closed
robertpang opened this issue Apr 19, 2019 · 1 comment
Closed

[YSQL] Avoid unnecessary index update preparation #1232

robertpang opened this issue Apr 19, 2019 · 1 comment
Assignees
Projects

Comments

@robertpang
Copy link
Contributor

@robertpang robertpang commented Apr 19, 2019

In YSQL, we prepare for index update when there are indices on the table. However, since the primary key, if defined, is the intrinsic part of a table, we should avoid the preparation for index update if a table contains just the primary key.

@robertpang robertpang self-assigned this Apr 19, 2019
@robertpang robertpang added this to To do in SQL Support via automation Apr 19, 2019
@robertpang robertpang moved this from To do to In progress in SQL Support Apr 19, 2019
yugabyte-ci pushed a commit that referenced this issue Apr 20, 2019
Summary:
This revision optimizes YSQL index updates by avoiding unnecessary index update preparation when there is no secondary index.
Specifically it correctly excludes from index updates the primary-key index (in primary-key-organized tables).

Test Plan: Jenkins

Reviewers: mihnea

Reviewed By: mihnea

Subscribers: neha, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D6502
@robertpang

This comment has been minimized.

Copy link
Contributor Author

@robertpang robertpang commented Apr 22, 2019

This enhancement has been made in commit 20d5227.

@robertpang robertpang closed this Apr 22, 2019
SQL Support automation moved this from In progress to Done Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
SQL Support
  
Done
1 participant
You can’t perform that action at this time.