Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QLTransactionTest.ResolveIntentsWriteReadWithinTransactionAndRollback fail in master #2411

Closed
spolitov opened this issue Sep 24, 2019 · 0 comments
Assignees
Labels

Comments

@spolitov
Copy link
Contributor

@spolitov spolitov commented Sep 24, 2019

No description provided.

@spolitov spolitov added the area/docdb label Sep 24, 2019
@spolitov spolitov self-assigned this Sep 24, 2019
@spolitov spolitov added this to To Do in YBase features via automation Sep 24, 2019
spolitov added a commit that referenced this issue Sep 25, 2019
Summary:
QLTransactionTest.ResolveIntentsWriteReadWithinTransactionAndRollback waits that all intents are cleaned at the end of the test.
It rely on automatic cleanup of intents of aborted transactions.
I.e. client transaction sends cleanup requests to all participanting replicas.

But 2 issues could happen:
1) When transaction is aborted on client, some replica did not yet receive intents for this transaction.
   So it does nothing on cleanup, but will add intents when they are received.
   Fixed by waiting that all transactions are replicated to all replicas.
2) Some replicas could fail in terms on meta cache, so cleanup request would not be send to them.
   Fixed by ignoring failed state, when taking replica list for cleanup.

Test Plan: ybd release --gtest_filter QLTransactionTest.ResolveIntentsWriteReadWithinTransactionAndRollback -n 300 -- -p 12

Reviewers: mikhail, timur

Reviewed By: timur

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7269
@spolitov spolitov closed this Sep 25, 2019
YBase features automation moved this from To Do to Done Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.