Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docdb] Better log rotation #3604

Open
ddorian opened this issue Feb 10, 2020 · 1 comment
Open

[docdb] Better log rotation #3604

ddorian opened this issue Feb 10, 2020 · 1 comment

Comments

@ddorian
Copy link
Contributor

@ddorian ddorian commented Feb 10, 2020

Hi

We need a better log rotation policy.
1 way is to keep static naming and allow another process to rotate: google/glog#19 (patch google/glog@58d7f87)

Another way would be to add an option glog_delete_after and a simple bg thread to enforce the policy. For now, having glog_delete_after=<size> should be a good start. It will take us a day or two to implement and probably save us devops trouble in different environments (k8s sidecar comes to mind).

@ddorian ddorian added the area/docdb label Feb 10, 2020
@ddorian ddorian changed the title [docdb] Better logrotation [docdb] Better log rotation Feb 10, 2020
@bmatican bmatican added this to To Do in YBase features via automation Feb 10, 2020
@bmatican bmatican removed their assignment Feb 10, 2020
@bmatican

This comment has been minimized.

Copy link
Contributor

@bmatican bmatican commented Feb 10, 2020

Opening this up for now, as the bg thread + size flag should not be too complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
YBase features
  
To Do
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.