Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDCServiceTxnTest.TestGetChangesForPendingTransaction frequently fails in master branch #4544

Closed
ttyusupov opened this issue May 21, 2020 · 0 comments
Closed

CDCServiceTxnTest.TestGetChangesForPendingTransaction frequently fails in master branch #4544

ttyusupov opened this issue May 21, 2020 · 0 comments
Assignees
@nspiegelberg
Labels
area/cdc Change Data Capture area/docdb YugabyteDB core features kind/failing-test Tests and testing infra
Projects
YBase features

Comments

@ttyusupov
Copy link
Contributor

ybd --remote release --cxx-test integration-tests_cdc_service-txn-test --gtest_filter CDCServiceTxnTest.TestGetChangesForPendingTransaction -n 100

~30% failures.
@ttyusupov ttyusupov added the kind/failing-test Tests and testing infra label May 21, 2020
@bmatican bmatican added area/cdc Change Data Capture area/docdb YugabyteDB core features labels May 21, 2020
@bmatican bmatican added this to To Do in YBase features via automation May 21, 2020
nspiegelberg added a commit that referenced this issue May 28, 2020
@nspiegelberg
[#4544] Fix Flakiness with TestGetChangesForPendingTransaction
07d96c5 
Summary:
As a result of #4257, we can now get into a race condition between Transaction->Flush() and
CDC.  Flush() waits for majority_replicated to return (this is correct) and CDC is more conservative
now and waits until committed to ensure all internal systems have processed the change.  It should
suffice to simply need a short poll because this is a small window based primarily on intra-cluster
RPC lag.

Test Plan: ybd --cxx-test integration-tests_cdc_service-txn-test --gtest_filter CDCServiceTxnTest.TestGetChangesForPendingTransaction -n 100

Reviewers: neha, sergei, timur, hector, bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8523
YBase features automation moved this from To Do to Done May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nspiegelberg nspiegelberg

Labels
area/cdc Change Data Capture area/docdb YugabyteDB core features kind/failing-test Tests and testing infra
Projects
YBase features
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmatican @ttyusupov @nspiegelberg