Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform] Enhance metrics that use sum without to also exclude namespace_name #9759

Open
bmatican opened this issue Aug 17, 2021 · 0 comments
Open

[platform] Enhance metrics that use sum without to also exclude namespace_name #9759

bmatican opened this issue Aug 17, 2021 · 0 comments
Assignees
@hsu880 @chidmuthu
Labels
area/platform Yugabyte Platform good first issue This is a good issue to start contributing!
Projects
Platform

Comments

@bmatican
Copy link
Contributor

We have a problem with Platform metrics, related to all the aggregations where we normally exclude tables (ie: sum without (table_id, table_name)), due to now also adding namespace_name into the Prometheus KV labels see https://yugabyte.slack.com/archives/C01HD5HPK8A/p1629237388110200?thread_ts=1628874648.049900&cid=C01HD5HPK8A for context

TL;DR: we probably need to augment all metrics.yml entries which use sum without, to also exclude namespace_name
I think the source of this is this diff from a long time back: https://phabricator.dev.yugabyte.com/D9182
@bmatican bmatican added the area/platform Yugabyte Platform label Aug 17, 2021
@hsu880 hsu880 added the good first issue This is a good issue to start contributing! label Aug 18, 2021
@hsu880 hsu880 added this to To do in Platform Aug 18, 2021
nkhogen added a commit that referenced this issue Oct 15, 2021
@nkhogen
[PLAT-1513] Enhance metrics that use sum without to also exclude name…
132805e 
…space_name (#9759)

Summary: Replace without with by to avoid changes when fields are added.

Test Plan: Tested by deploying manually and checking to see if the API response payloads are correctly populated.

Reviewers: amitanand, sanketh

Reviewed By: sanketh

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D13309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsu880 hsu880

@chidmuthu chidmuthu

Labels
area/platform Yugabyte Platform good first issue This is a good issue to start contributing!
Projects
Platform
  
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmatican @hsu880 @chidmuthu