Add maven dependency, remove library code from repository #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add + org.json:json:20170516 + commons-codec:commons-codec:1.10
|
@Hiroyuki-Nagata : Thanks for letting us know this one. I will review the commit and merge it once if everything goes well. Comments from Reviewable |
|
Reviewed 21 of 21 files at r1. Comments from Reviewable |
There was a problem hiding this comment.
Seems good to add maven dependency rather then using classes directly. @yugandhargangu : Is it good to add dependency or you want to keep this as classes only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I saw your repository.
There are several library code in the repository.
So, I removed codes derived from libraries, then added maven dependency.
I added following libraries:
Please check it.
This change is