Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pure-help-block #32

Merged
merged 1 commit into from Jun 3, 2013
Merged

Added pure-help-block #32

merged 1 commit into from Jun 3, 2013

Conversation

its-danny
Copy link
Contributor

I noticed there's already a pure-help-inline, so I went ahead and added a block version. Might be useful to have them in the docs as well, I use them quite a bit when using Bootstrap.

@tilomitra
Copy link
Contributor

Thanks, this is helpful. I'll pull this down and test it locally.

@ghost ghost assigned tilomitra May 29, 2013
@tilomitra
Copy link
Contributor

@dannytatom This looks good. I'm pulling it in, but I changed .pure-help-block, to just .pure-help. Objections?

@its-danny
Copy link
Contributor Author

Looks better to me, I went with -block only because the other is -inline.

@tilomitra
Copy link
Contributor

I think we can assume *-block by default. I also removed the margins because it seems to work better without it. It's closer to the actual input element. Otherwise, the pure-help-inline and pure-help don't have equal margins on small screens (because the pure-help-inline doesn't have a default margin. Here's how it looks now:

/* Block help for forms */
.pure-form .pure-help {
  display: block;
  color: #666;
  font-size: 90%;
}

@its-danny
Copy link
Contributor Author

Looks good to me, thanks for the rundown. 😀

@tilomitra
Copy link
Contributor

@dannytatom Thanks dude. Would you mind signing this CLA so that I can merge this in? We need a signed CLA to merge stuff in. I'm going to add this to the README.md.

@its-danny
Copy link
Contributor Author

@tilomitra Signed! And no problem, hopefully I can get around to working a bit more on it, huge fan so far.

@ericf
Copy link
Collaborator

ericf commented May 31, 2013

@tilomitra pure-help doesn't signal to me what it actually does. I feel that pure-inline and pure-block are much more helpful and could be used outside of a descendent pure-form selector. That said, do we really need this at all, if they are going to be scoped to forms, then couldn't we have pure-form-inline?

@tilomitra
Copy link
Contributor

@ericf So pure-form-help-inline and pure-form-help? pure-form-inline can be confused with the inline form.

@ericf
Copy link
Collaborator

ericf commented Jun 3, 2013

Remove "help" it's meaningless. Pure's whole goal is to "help" :P

@its-danny
Copy link
Contributor Author

I think it makes sense to be there, as it's used (at least inline is) to give a tip about the form element it's next to or under. pure-block and pure-inline sound like they're alignment classes.

@ericf
Copy link
Collaborator

ericf commented Jun 3, 2013

So again, my vote on naming is here: #32 (comment)

@tilomitra
Copy link
Contributor

I agree with @dannytatom that pure-block and pure-inline don't work. help by itself would be vague, which is why I am suggesting pure-form-help-inline and pure-form-help/pure-form-help-block.

If "help" is an issue, we can change it to "message":

  • pure-form-message-inline
  • pure-form-message

@ericf
Copy link
Collaborator

ericf commented Jun 3, 2013

Ah, okay, I wasn't understanding "help" I thought it meant, help-make-forms-inline. I see now that it's for help text directed at the person using the form :)

I think "message" is better and clearer that it has nothing to do with CSS, but rather helping layout a part of form, the text to help the user fill out the form.

@tilomitra
Copy link
Contributor

So are we cool with pure-form-message-inline and pure-form-message? I can make the appropriate changes to @dannytatom's commit and merge it in.

@ericf
Copy link
Collaborator

ericf commented Jun 3, 2013

@tilomitra I am. Be sure to update the HISTORY.md with a (!) to signal possible back-compat breakage. And on that note, we should leave in (but mark as deprecated) the pure-help* selectors.

@tilomitra tilomitra merged commit 8e38086 into pure-css:master Jun 3, 2013
@tilomitra
Copy link
Contributor

@dannytatom Thanks dude. Merged and closed.

@freshface
Copy link

Is it possible to provide an example on how to use these classes?

@ghost
Copy link

ghost commented Oct 30, 2013

@freshface You can find many examples on the project's website at http://purecss.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants