Support including transitive dependencies #107

Open
jafl opened this Issue Oct 31, 2013 · 4 comments

Comments

Projects
None yet
3 participants

jafl commented Oct 31, 2013

When building gallery modules, it would be neat if shifter could augment the "requires" list with transitive dependencies within the gallery. So if gallery-a depends on gallery-b, and gallery-b depends on gallery-c and gallery-d, then gallery-a would list all three modules.

The big reason for this is that it would reduce the number of request to the gallery and make pages load faster. Instead of 3 requests (gallery-a, then gallery-b, then gallery-c and gallery-d), it would only requires 2 requests (gallery-a, then gallery-b, gallery-c, and gallery-d). The deeper the dependency tree, the bigger the savings.

Owner

caridy commented Oct 31, 2013

this is a no-go because of the potential inconsistencies with the dependencies. for example, if the gallery-c changes, and it stops depending on gallery-d, then you ended up in a situation where:

a) you have to updates all the affected gallery modules on every gallery push
b) you end up with inconsistencies in your application

now, the solution that we are recommending for this kind of stuff is to expand metadata per app, rather than doing it at the library or gallery level.

Contributor

evocateur commented Nov 1, 2013

the solution that we are recommending for this kind of stuff is to expand metadata per app, rather than doing it at the library or gallery level.

@caridy What tool would that be?

Owner

caridy commented Nov 1, 2013

we are working on an app-level tool that will help you to generate the loader config using grunt, for now the only solution is to use locator and locator-yui to generate the meta module. we will be sharing more about this during yuiconf.

Contributor

evocateur commented Nov 1, 2013

Looking forward to it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment