Can't skip lint on individual modules within a build.json #61

Closed
earnubs opened this Issue Jan 22, 2013 · 5 comments

Comments

Projects
None yet
6 participants
@earnubs
Contributor

earnubs commented Jan 22, 2013

I have several modules which are precompiling handlebars and Template.Micro templates as part of the 'exec' step, making them available to shifter to parcel up into modules for their revelvant apps.

While I want lint on all the other modules in that build.json, I would like shifter to not lint the precompiled template modules. Something like:

 {
   "name": "foo",
   "builds": {
    "foo-templates": {
       "jsfiles": [
         "./js/templates/app.hbs.js"
       ],
       "exec": [
           "precompile ./assets/tmpl/app.hbs"
       ],
       "config": {
           "lint": false,
           "requires": [
               "handlebars-base"
          ]
       }
    },
     "foo-app": { ... },
     "foo-view": { ... },
}

@ghost ghost assigned davglass Jan 22, 2013

@davglass

This comment has been minimized.

Show comment Hide comment
@davglass

davglass Jan 22, 2013

Member

Right now it's "build file" specific & it's under the shifter namespace since it's a shifter override:

{
   "name": "foo",
   "shifter": {
      "lint": false
   }
}

I'll see if I can expand this on my next update.

Member

davglass commented Jan 22, 2013

Right now it's "build file" specific & it's under the shifter namespace since it's a shifter override:

{
   "name": "foo",
   "shifter": {
      "lint": false
   }
}

I'll see if I can expand this on my next update.

@evocateur

This comment has been minimized.

Show comment Hide comment
@evocateur

evocateur Jan 22, 2013

Contributor

I wonder if parsing .jshintignore files like jshint's CLI does would be worthwhile? There is a sort-of precedent in shifter's fetchJSHintConfig internal method. Although, it would get rather bothersome to copy ignore files all over the place...

Contributor

evocateur commented Jan 22, 2013

I wonder if parsing .jshintignore files like jshint's CLI does would be worthwhile? There is a sort-of precedent in shifter's fetchJSHintConfig internal method. Although, it would get rather bothersome to copy ignore files all over the place...

@semafor

This comment has been minimized.

Show comment Hide comment
@semafor

semafor Jun 1, 2013

+1

semafor commented Jun 1, 2013

+1

@ianstigator

This comment has been minimized.

Show comment Hide comment
@ianstigator

ianstigator Sep 4, 2014

Contributor

+1

Contributor

ianstigator commented Sep 4, 2014

+1

@caridy

This comment has been minimized.

Show comment Hide comment
@caridy

caridy Sep 5, 2014

Member

no new feature will be added in shifter!

Member

caridy commented Sep 5, 2014

no new feature will be added in shifter!

@caridy caridy closed this Sep 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment