First pass at addressing parse build.json issue. #105 #106

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@tripp
tripp commented Oct 18, 2013

Not sure if this is the best fix but it can at least act as a strawman for addressing #105.

@caridy
Member
caridy commented Oct 18, 2013

LGTM

@caridy
Member
caridy commented Apr 15, 2014

@tripp is this still valid or should we close it?

@tripp
tripp commented Apr 15, 2014

@caridy This bug still looks valid.

Its a very edge case that has only come up once in a gallery build. If a module has a build.properties file and no build.json, a build.json is constructed but a hard line break appears at the end of the module name in its files and in the directory.

@tripp
tripp commented Apr 15, 2014

ping @ekashida
ping @clarle
Have either of you guys run into this doing a gallery build?

@ekashida

I have never run into this issue

@caridy
Member
caridy commented Apr 15, 2014

@clarle can we close this?

@caridy
Member
caridy commented Jun 9, 2014

Closing, let's reopen if needed. /cc @tripp @clarle

@caridy caridy closed this Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment