New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating gear dependencies to fix broken shifter / gear-lib call to .replace() #111

Merged
merged 1 commit into from Nov 25, 2013

Conversation

Projects
None yet
3 participants
@aversini
Contributor

aversini commented Nov 23, 2013

This is to fix issue #110

gear-lib v0.8.12 doesn't provide "replace" nor "stamp" anymore. Both methods are now moved to gear v0.8.16

Shifter on the other hand, requires gear "~0.7.0" and gear-lib "~0.8.0" which means that it actually (as of today) installs gear v0.7.16 and gear-lib v0.8.12 (which are now incompatible).

So when Shifter tries to call "replace", it just generates the following error:
/usr/local/lib/node_modules/shifter/lib/module.js:324
queue.replace(replaceOptions);
^
TypeError: Object # has no method 'replace'
at Object.buildJS

@clarle clarle merged commit a0d1e4d into yui:master Nov 25, 2013

1 check failed

default The Travis CI build failed
Details
@evocateur

This comment has been minimized.

Show comment
Hide comment
@evocateur

evocateur Nov 25, 2013

Contributor

There are some disturbing lint errors that crept in at some point in the past (not this PR). The change actually passes the tests, despite the Travis failure.

Contributor

evocateur commented Nov 25, 2013

There are some disturbing lint errors that crept in at some point in the past (not this PR). The change actually passes the tests, despite the Travis failure.

@clarle

This comment has been minimized.

Show comment
Hide comment
@clarle

clarle Nov 25, 2013

Contributor

Fixed, thanks for the patch.

@evocateur I'm going to pull in your lint changes now so Travis actually passes.

Contributor

clarle commented Nov 25, 2013

Fixed, thanks for the patch.

@evocateur I'm going to pull in your lint changes now so Travis actually passes.

@evocateur

This comment has been minimized.

Show comment
Hide comment
@evocateur

evocateur Nov 25, 2013

Contributor

@clarle Thanks!

Contributor

evocateur commented Nov 25, 2013

@clarle Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment