Replace `which` calls to avoid exceptions when shifter is not installed globally. #43

Closed
wants to merge 7 commits into from

2 participants

@ryanvanoss

Well, this fixes it for local requires, but breaks it for global installs. Will update with a better fix.

ryanvanoss added some commits Nov 1, 2012
@ryanvanoss ryanvanoss Revert "Replace `which` commands to avoid exceptions when shifter is …
…not installed globally."

This reverts commit 7036a7803c8294b6378c7eeeb8e52b4bbe87a536.
95f5914
@ryanvanoss ryanvanoss Revert "Linting."
This reverts commit 15057789dbcf57a11b5690c865297ffe42a35380.
b4fdcc5
@ryanvanoss ryanvanoss Revert "More linting..."
This reverts commit 396117283de625ff697ce380c3d1b60ab145c000.
ebb8f25
@ryanvanoss ryanvanoss Add binPath to find local binary in case `which` throws an exception. 1b5cfc3
@davglass davglass closed this in b7614dc Dec 10, 2012
@davglass davglass reopened this Dec 10, 2012
@davglass
YUI Library member

This shouldn't have closed from a different branch :(

Can you install shifter from the internal branch and give it a test?

npm install https://github.com/yui/shifter/archive/internal.tar.gz

This should allow for better internal usage since it won't go out of the shifter repo to find the shifter bin to execute sub builds, walks, watches, etc..

@ryanvanoss

Works for me. Thanks Dav.

@davglass
YUI Library member

Great, I'll merge this in with my local updates and get a release out in a few..

@davglass
YUI Library member

This is in shifter@0.2.12

@davglass davglass closed this Dec 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment