GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
As raised ticket #67 describes,
there was an issue in Windows 7, the root of the issue was a bug in the complete module 0x00A/complete@eab9c1f,
so the yogi fix consist in an update of the package.json file to use the latest npm build
of the complete module,
Windows 7 issue fixed
Merge pull request #69 from asotog88/master
Windows 7 issue fix
Published in firstname.lastname@example.org, thanks!
This is now breaking our travis builds :(
Thats weird going to take a look, as you see the only change https://github.com/hij1nx/complete/commits/master was to use process.env.USERPROFILE instead of process.env.HOME when it was undefined, to make it work on windows, maybe something has changed from previous releases from 0.3.1 to 0.4.2 version
I filed a PR (hij1nx/complete#19) to add a throw in this case instead of a process.exit. Then yogi can try/catch this the proper way.
I added in a quick hack to yogi to skip this when the TRAVIS env var is set. Once my PR lands, I'll update to that version and wrap it in a proper try/catch.
Awesome man, thats cool, thanks