Windows 7 issue fix #69

Merged
merged 1 commit into from Apr 4, 2013

Conversation

Projects
None yet
2 participants
Contributor

asotog commented Apr 4, 2013

Hi team,

As raised ticket #67 describes,
there was an issue in Windows 7, the root of the issue was a bug in the complete module 0x00A/complete@eab9c1f,
so the yogi fix consist in an update of the package.json file to use the latest npm build
of the complete module,

Thanks,

davglass added a commit that referenced this pull request Apr 4, 2013

@davglass davglass merged commit 5cf1d25 into yui:master Apr 4, 2013

1 check passed

default The Travis build passed
Details
Owner

davglass commented Apr 4, 2013

Published in yogi@0.1.4, thanks!

Owner

davglass commented Apr 4, 2013

This is now breaking our travis builds :(

https://travis-ci.org/yui/yui3/jobs/6053541

Contributor

asotog commented Apr 4, 2013

Thats weird going to take a look, as you see the only change https://github.com/hij1nx/complete/commits/master was to use process.env.USERPROFILE instead of process.env.HOME when it was undefined, to make it work on windows, maybe something has changed from previous releases from 0.3.1 to 0.4.2 version

Owner

davglass commented Apr 4, 2013

I filed a PR (hij1nx/complete#19) to add a throw in this case instead of a process.exit. Then yogi can try/catch this the proper way.

I added in a quick hack to yogi to skip this when the TRAVIS env var is set. Once my PR lands, I'll update to that version and wrap it in a proper try/catch.

Contributor

asotog commented Apr 4, 2013

Awesome man, thats cool, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment