Here is a file (YUI2 concatenated JS file) where minification with yuglify goes horribly wrong:
When I remove the license comments (starting with /*!) everything is fine.
For what goes wrong see http://yuilibrary.com/forum/viewtopic.php?f=18&t=11476
I've patched this on the comments branch, can you pull that and install it to test with to confirm?
Well, no. I put the minified result at https://gist.github.com/4216487
Check what's supposed to be just before the EASING EQUATIONS license comment in the raw file (gist above) with what I get.
Latest patch in branch "comments" works.
I'll merge this in next week after the 3.8.0 release along with the other pull request I have open.
Hi, this still hasn't made it to the master branch.
Any chance of getting it merged?
I got the same problem with MapBox's Wax library (specifically, wax-leaf.js) and can confirm that it works with the comments branch.
Not sure why this was closed, since it was I completely missed it. I'll have to check into it again since the comments branch no longer merges cleanly.
Sorry for that, I guess I had thought the branch would be merged before the new release - and I've the fetish to always close everything as soon as it looks like it's no longer needed, tickets, desktop apps not used >3min, etc. :)
I usually let Github do it when it's actually merged :)
This was not nearly as easy as merging the branches, when I merged that in all of the shifter tests failed as did the YUI tests.
Is there any progress on this issue? I am experiencing this and I'd like to help if possible. I see the comments branch is way behind, is it worth rebasing and seeing if I can make it pass the test suite? Is the fix applied there correct? Thanks