Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

dom-style should not require color-base #1621

Closed
mschipperheyn opened this Issue Feb 9, 2014 · 2 comments

Comments

Projects
None yet
2 participants

While I use setStyle regularly, I never use colors using setStyle. That's for stylesheets. I don't understand why color-base is a requisite for dom-style and I would recommend removing it. It's an edge case scenario that pretty much gets loaded each and every time because of this dependency.

Member

okuryu commented Feb 9, 2014

@mschipperheyn It seems to be have resolved since 3.10.2 (PR #576). Could you try the latest version?

@okuryu okuryu added a commit to okuryu/yui3 that referenced this issue Mar 3, 2014

@okuryu okuryu [dom] Move color-base out of dom-style
This change resolves an oversight in #576. Fix #1621.
e56b04f

@okuryu okuryu added a commit to okuryu/yui3 that referenced this issue Mar 4, 2014

@okuryu okuryu [dom] Move color-base out of dom-style
This change resolves an oversight in #576. Fix #1621.
db39c3d

@okuryu okuryu added a commit to okuryu/yui3 that referenced this issue Mar 17, 2014

@okuryu okuryu [dom] Move out of color-base module
Currently, the `dom-style` module depends on `color-base` module only for
falling back to calculate computed style on legacy Opera (<= 12), but the
latest Opera (15+) is almost the same Chrome (`Y.UA.webkit` returns truth
actually). Many core modules are depending the `dom-style` module, I expect
that many YUI modules and applications will have derived not a little
benefit to faster by this change. I also hope that this resolves #1621.
191d224

@okuryu okuryu added a commit to okuryu/yui3 that referenced this issue Mar 17, 2014

@okuryu okuryu [dom] Move out of color-base module
Currently, the `dom-style` module depends on `color-base` module only for
falling back to calculate computed style on legacy Opera (<= 12), but the
latest Opera (15+) is almost the same Chrome (`Y.UA.webkit` returns truth
actually). Many core modules are depending the `dom-style` module, I expect
that many YUI modules and applications will benefit to faster from more
than a little by this change. I also hope that this resolves #1621.
b169713

@okuryu okuryu self-assigned this Apr 11, 2014

Member

okuryu commented Apr 11, 2014

#1709 has been merged into dev-3.x branch. It will be available in the future release. I hope this issue resolved.

@okuryu okuryu closed this Apr 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment