[dom] Move out of color-base module #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `dom-style` module depends on `color-base` module only for falling back to calculate computed style on legacy Opera (<= 12), but the latest Opera (15+) is almost the same Chrome (`Y.UA.webkit` returns truth actually). Many core modules are depending the `dom-style` module, I expect that many YUI modules and applications will benefit to faster from more than a little by this change. I also hope that this resolves yui#1621.
|
CLA is valid! |
|
👍 A few of us were wondering the same thing. Let's get this in. |
|
@ezequiel Thanks. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
dom-stylemodule depends oncolor-basemodule only for falling back to calculate computed style on legacy Opera (<= 12), but the latest Opera (15+) is almost the same Chrome (Y.UA.webkitreturns truth actually). Many core modules are depending thedom-stylemodule, I expect that many YUI modules and applications will benefit to faster from more than a little by this change. I also hope that this resolves #1621.I'd like to push this into the
dev-3.xbranch because this changes are across some module's dependencies. And I will rebuildanim,dom,loader,graphicsmodules and update theHISTORY.mdfordommodule when this has been merged.Note: The
dom-style-iemodule will still depends on thecolor-basemodule for the legacy IE (<= 8.0).