New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History Hash's parseHash() does not handle blank values #1116

Merged
merged 4 commits into from Aug 22, 2013

Conversation

Projects
None yet
3 participants
@blzaugg
Copy link
Contributor

blzaugg commented Aug 20, 2013

Hash strings such as: #foo=bar&baz=&qu=ux or #foo=bar&baz&qu=ux fail because _REGEX_HASH does not allow blank values.

@blzaugg

This comment has been minimized.

Copy link
Contributor

blzaugg commented Aug 20, 2013

@rgrove new pull with your suggested changes.

@rgrove

This comment has been minimized.

Copy link
Contributor

rgrove commented Aug 20, 2013

@blzaugg 👍 Looks good to me, thanks!

I'll leave this open for a while to allow other folks time to comment, then I'll merge if there are no further objections.

if (param.length > 1) {
params[decode(param[0])] = decode(param[1]);
} else {
params[decode(match)] = '';

This comment has been minimized.

@ericf

ericf Aug 21, 2013

Member

+1 for default to an empty string for the value.

@ericf

This comment has been minimized.

Copy link
Member

ericf commented Aug 21, 2013

LGTM. @blzaugg thanks for include tests and HISTORY updates, makes the merge nice and easy :)

@rgrove rgrove merged commit dcd509d into yui:dev-master Aug 22, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment