New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widget] Remove widget-locale module #1117

Merged
merged 4 commits into from Aug 23, 2013

Conversation

Projects
None yet
2 participants
@okuryu
Copy link
Member

okuryu commented Aug 21, 2013

The widget-locale module has been deprecated 3 years ago. So we already providing intl module instead. Also, fix #936 by this change.

Remove widget-locale module
The widget-locale module has been deprecated 3 years ago. So we
already providing intl module instead. Also, fix #936 by this change.
@ericf

This comment has been minimized.

Copy link
Member

ericf commented Aug 22, 2013

LGTM. Feel free to merge this in, and when you do could you make sure to add a HISTORY entry for the removal, and also git rm the related build/ files?

@okuryu

This comment has been minimized.

Copy link
Member

okuryu commented Aug 22, 2013

  • Removed widget-locale from Loader meta data
  • Removed build files
  • Updated the HISTORY
@ericf

This comment has been minimized.

Copy link
Member

ericf commented Aug 22, 2013

@okuryu looks good, :shipit:

@ghost ghost assigned okuryu Aug 22, 2013

@okuryu

This comment has been minimized.

Copy link
Member

okuryu commented Aug 23, 2013

@ericf Thanks for your review. Merging this..

@okuryu okuryu merged commit 83cc5cf into yui:dev-3.x Aug 23, 2013

1 check passed

default The Travis CI build passed
Details

@okuryu okuryu deleted the okuryu:fix-936 branch Aug 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment