New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1167. Add Show All to Lang packs. #1173

Merged
merged 4 commits into from Sep 16, 2013

Conversation

Projects
None yet
3 participants
@apipkin
Copy link
Contributor

apipkin commented Sep 9, 2013

Show All was requested to be added to the lang packs of DataTable Paginator. Since this is coming in as an array from the ATTRS, Controller and View both need to read their own Strings package in. Also created a test to switch between en and fr langs to check for the correct verbiage in use.

Fixes issue #1167

Ping @Naouak

  • Test
  • Code Fix
  • History
  • Sign Off or 3 days
@clarle

This comment has been minimized.

Copy link
Contributor

clarle commented Sep 9, 2013

👍, looks good!

@Naouak

This comment has been minimized.

Copy link

Naouak commented Sep 10, 2013

Didn't have time to look through it yet. I will add the translation as soon as I have access to my work computer.

@clarle

This comment has been minimized.

Copy link
Contributor

clarle commented Sep 10, 2013

@Naouak I helped with the translation, though I'm not a native French speaker, so it would be great if you can confirm. Does "Afficher tout" == "Show all" make sense?

@apipkin apipkin merged commit 38b2eed into yui:dev-master Sep 16, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment