New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT] Add Highlight module to DataTable #1196

Merged
merged 12 commits into from Sep 26, 2013

Conversation

Projects
None yet
2 participants
@apipkin
Copy link
Contributor

apipkin commented Sep 16, 2013

Adds the ability to move the mouse over a cell and highlight the row, column and/or cell.

Individual highlight modes makes it possible to highlight a row and column and cell. Any highlight mode can be turned on or off independently.

  • Test
  • Code Fix
  • History
  • Sign Off or 3 days
@rgrove

This comment has been minimized.

Copy link
Contributor

rgrove commented Sep 16, 2013

I hate to start a naming discussion, but...it seems like "datatable-highlight" could easily be confused as being related to the "highlight" module (http://yuilibrary.com/yui/docs/api/modules/highlight.html), when really they do very different things.

Why not call this "datatable-hover"?

@apipkin

This comment has been minimized.

Copy link
Contributor

apipkin commented Sep 16, 2013

@rgrove do you think it's a matter of context that "highlight" comes with an understanding when related to DataTable as opposed to outside DataTable. I'm not grounded on the name, but if the structure of highlighting moves beyond mouse interaction and gets aria added in after keyboard navigation is added in, hover wouldn't be the best way to go then either, right?

@rgrove

This comment has been minimized.

Copy link
Contributor

rgrove commented Sep 16, 2013

If the highlighting feature may one day support focus-based highlighting as well, then I agree that "-hover" would be a bad name. I guess "-highlight" is fine as long as the docs are explicit about what kind of highlighting is being done, so that people don't assume it's somehow related to what the "highlight" module does.

@apipkin

This comment has been minimized.

Copy link
Contributor

apipkin commented Sep 16, 2013

@rgrove Yeah I'll be sure to add that too the docs!

@apipkin

This comment has been minimized.

Copy link
Contributor

apipkin commented Sep 26, 2013

---------------------------------+-----------+-----------+-----------+-----------+
File                             |   % Stmts |% Branches |   % Funcs |   % Lines |
---------------------------------+-----------+-----------+-----------+-----------+
   datatable-highlight/          |       100 |       100 |       100 |       100 |
      datatable-highlight.js     |       100 |       100 |       100 |       100 |
---------------------------------+-----------+-----------+-----------+-----------+

@apipkin apipkin merged commit e34f842 into yui:dev-3.x Sep 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment