bound the right context to the aftersubscriber of _afterIdChange #1499

Closed
wants to merge 1 commit into from

3 participants

@ItsAsbreuk

making 'this; refer to the ML-instance inside _afterIdChange

@ItsAsbreuk ItsAsbreuk bound the right context to the aftersubscriber of _afterIdChange
making 'this; refer to the ML-instance inside _afterIdChange
7e34d40
@rgrove

Just as with #1498, we seem to already have a test that covers this case, and it's already passing. Can you explain why this change is necessary and provide a failing test case that demonstrates the problem you're trying to solve?

@ItsAsbreuk

Actually, i didn't encounter an error on this one.
Because of #1498 i think you always need to specify the context when calling methods by reference.

@triptych

@ItsAsbreuk do you have time to revisit this PR and address the issues @rgrove mentioned?

@rgrove

Closing. This is a problem in implementation code, not the library.

@rgrove rgrove closed this Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment