Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yui: Fix skin tests for latest Chrome/Android 4.4 #1501

Closed
wants to merge 1 commit into from
Closed

yui: Fix skin tests for latest Chrome/Android 4.4 #1501

wants to merge 1 commit into from

Conversation

@clarle
Copy link
Collaborator

@clarle clarle commented Dec 16, 2013

New Chrome and Android return the full value declaration with getComputedStyle for font properties such as textDecoration. They return:

underline solid rgb(0, 0, 0)

Instead of just:

underline

Since we don't normalize getComputedStyle for shorthand like that, the tests just need to be fixed.

\cc @msweeney

New Chrome and Android use the full value declaration for
font properties such as `textDecoration`. They return:

`underline solid rgb(0, 0, 0)`

Instead of just:

`underline`
@lsmith
Copy link
Contributor

@lsmith lsmith commented Dec 17, 2013

If Chrome for android is returning font declaration value from requests for font-decoration, that's a bug and should be filed with the browser.

Fixing the tests is reasonable, but if that's a supported environment (@msweeney), dom-style should be fixed, no?

@clarle
Copy link
Collaborator Author

@clarle clarle commented Dec 17, 2013

@lsmith @msweeney:

On the W3 spec for CSS3 text-decoration, it mentions that omitted values should be set to their initial values. solid and rgb(0, 0, 0) refer to the underline, in this case:

http://www.w3.org/TR/css-text-decor-3/#text-decoration

Technically Chrome/Android 4.4 are following spec in this case. The thing is whether we want to normalize this across browsers or not, but I think @msweeney mentioned we don't do that for things like fonts.

@lsmith
Copy link
Contributor

@lsmith lsmith commented Dec 17, 2013

Thanks! gtk.

@clarle
Copy link
Collaborator Author

@clarle clarle commented Dec 17, 2013

Merged in 332fed9.

@clarle clarle closed this Dec 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants