Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Resolution of several issues in IE 11. #1505

Merged
merged 6 commits into from Dec 17, 2013

Conversation

@ezequiel
Copy link
Contributor

@ezequiel ezequiel commented Dec 17, 2013

IE 11 now supports Node.textContent, and Window.getSelection.

Unfortunately, Y.Editor relies heavily on user agent strings, and therefore a several places needed updating.

test_bidi_plug: (Y.UA.ie && Y.UA.ie >= 9),
test_selection_methods: ((Y.UA.ie || Y.UA.webkit) ? true : false),
test_execCommands: ((Y.UA.ie && Y.UA.ie >= 9) ? true : false)
test_bidi_plug: Y.UA.ie && (Y.UA.ie === 9 || Y.UA.ie === 10),

This comment has been minimized.

@okuryu

okuryu Dec 17, 2013
Member

It may make more sense to test_bidi_plug: (Y.UA.ie === 9 || Y.UA.ie === 10),.

test_execCommands: ((Y.UA.ie && Y.UA.ie >= 9) ? true : false)
test_bidi_plug: Y.UA.ie && (Y.UA.ie === 9 || Y.UA.ie === 10),
test_selection_methods: (Y.UA.ie && Y.UA.ie < 11) || Y.UA.webkit,
test_execCommands: Y.UA.ie && (Y.UA.ie === 9 || Y.UA.ie === 10)

This comment has been minimized.

@okuryu

okuryu Dec 17, 2013
Member

Same here.

test_selection_methods: ((Y.UA.ie || Y.UA.webkit || (Y.UA.gecko && Y.UA.gecko >= 12 && Y.UA.gecko < 23)) ? true : false),
test_execCommands: ((Y.UA.ie && Y.UA.ie >= 9) ? true : false),
test_selection_methods: (Y.UA.ie && Y.UA.ie < 11) || Y.UA.webkit || (Y.UA.gecko && Y.UA.gecko > 11 && Y.UA.gecko < 23),
test_execCommands: Y.UA.ie && (Y.UA.ie === 9 || Y.UA.ie === 10),

This comment has been minimized.

@okuryu

okuryu Dec 17, 2013
Member

Same here.

@lsmith
Copy link
Contributor

@lsmith lsmith commented Dec 17, 2013

I agree with @okuryu's comments about removing the unnecessary truthy test of Y.UA.ie.

Otherwise, LGTM

@ezequiel
Copy link
Contributor Author

@ezequiel ezequiel commented Dec 17, 2013

At the time, the extra check sounded like a nice idea, but looking back; probably not.

Thanks.

@ezequiel ezequiel merged commit b2043a8 into yui:release-3.14.1 Dec 17, 2013
1 check passed
1 check passed
@davglass
default The Travis CI build passed
Details
@ezequiel ezequiel deleted the ezequiel:editor-fix-part-2 branch Jan 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants