Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix event-outside delegate and an error when defining and using `tapoutside` #1608

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

dpobel commented Feb 4, 2014

First, I'm sorry for the pull request mixing two different issues, it happens that I found that the outside delegate does not work at all and does not support filtering with a selector while fixing the tapoutside issue and to properly test it, I need the delegate method to work correctly...

Anyway, this PR does 2 things:

  • fix event-outside delegate to work with and without a filter selector (fix the tests and add new tests)
  • fix the "has no method 'isOutside'" when defining and using tapoutsite (with a regression test)
Contributor

tilomitra commented Feb 4, 2014

Thanks for the PR @dpobel! What browsers did you test this on?

dpobel commented Feb 5, 2014

Hi @tilomitra

to be honest before your comment, I tested only with PhantomJS, Firefox (Linux) and Chrome (Linux) without any problem. So, in addition, I've just tested with yeti on Firefox Android, Chrome Android, Chrome Window7, IE8, IE9 and IE10 (that's all I have on my machines at the moment :)) and unfortunately, the unit tests on tapoutside fail for:

  • Firefox Android
  • IE 10

for Firefox Android, I have a message about simulateTouchEvent not being supported but since it's not listed in the supported env. so I guess that's OK for now.

for IE10, my quick manual tests confirm that tapoutside is working as expected (at least with on('tapoutside')), so it seems like the issue lies in the simulateGesture('tap'), is it a known issue ? I've noticed that it's not much used in others unit tests and you usually test the tap event in a different way with the definition of lower level helpers, is it the way to go?

F21 commented Mar 2, 2014

Any updates on this? I am finding that delegate doesn't work with event outside being a bit of a limitation.

dpobel commented Mar 3, 2014

I had not the time to work on this in the mean time and the fact the tests are failing in IE10 is not a big source of motivation;-)
More seriously, I'll try to find some time this week to at least dig what is wrong in IE10 and simulateGesture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment