Remove src attribute in iFrame used in io-upload-iframe (Fix #1622) #1646

Merged
merged 246 commits into from Mar 26, 2014

Conversation

Projects
None yet
Contributor

goodforenergy commented Feb 20, 2014

Removing the problematic src attribute from the iFrame used in io-upload-iframe to enable file uploading. Fixes issue #1622.

shunner and others added some commits Aug 2, 2013

@shunner shunner Merge remote-tracking branch 'upstream/master' 672a7c5
Ezequiel Rodriguez DataTable: Convert value from `input` element into a number. 875b733
Clarence Leung datatable: Fix incorrect dependencies in docs
Resolves #1411.
8851152
Clarence Leung Merge branch 'live-docs' into dev-master b8720fa
@opichals opichals Added missing base-core dependency to base-observable meta f54e8a7
@ericf ericf Build BaseObservable 27e79ea
@ericf ericf Build Paginagor and Gesture Simulate coverage files 3e1b95e
@ericf ericf Build YUI 3f7e332
Clarence Leung Merge branch 'release-3.14.0' into live-docs 050e980
Clarence Leung Merge branch 'live-docs' into dev-master
Conflicts:
	build/loader-yui3/loader-yui3-coverage.js
	build/loader-yui3/loader-yui3-debug.js
	build/loader-yui3/loader-yui3-min.js
	build/loader-yui3/loader-yui3.js
	build/loader/loader-debug.js
	build/loader/loader-min.js
	build/loader/loader.js
	build/yui-nodejs/yui-nodejs-debug.js
	build/yui-nodejs/yui-nodejs-min.js
	build/yui-nodejs/yui-nodejs.js
	build/yui/yui-debug.js
	build/yui/yui-min.js
	build/yui/yui.js
	src/loader/js/yui3.js
16bf770
Clarence Leung Add new VERSION entries for HISTORY.md files 2afbddf
Clarence Leung Bump metadata JSON to 3.14.1-pre 1bd8c63
@juandopazo juandopazo [datatype-number] Clean up Number.parse 878d423
@okuryu okuryu Ignore running some tests by Yeti in Calendar tests
Currently, running Calendar tests containing the focus process will
fail in Firefox. The cause of this problem seems to be a problem that
test case is not bad, what happens if you are running Yeti while running
Firefox in the background. This problem does not occur in a browser
other than Firefox. In addition, there is a test that includes a focusing
process in the same way the Widget Button module [1], but it has to
ignore Yeti is here. Therefore, I would like to ignore running some tests
by Yeti in the same way in Calendar. Fix #1363.

[1]: src/widget-buttons/tests/unit/assets/widget-buttons-test.js
362931c
Ezequiel Merge remote-tracking branch 'origin/xml-fix' into dev-master 6177186
Ezequiel Merge remote-tracking branch 'origin/dt-page-fix-part2' into dev-master dfa9ff2
Ezequiel DataTable, DataType, Paginator: Build. c7dd1c5
@andrewnicols andrewnicols Correct casing for Y.Log -> Y.log babc96b
Ezequiel WidgetModality: Build. 8ea8682
@stonebk stonebk Fix #1455 17589a9
Ezequiel Merge remote-tracking branch 'stonebk/dev-master' into dev-master
Conflicts:
	src/event/js/tap.js
a4c1936
Ezequiel Event: Build. 61fcfbc
Ezequiel Merge remote-tracking branch 'juandopazo/number-parse' into dev-master e0ad9de
Ezequiel Number: Build. a3c9524
@zhiyelee zhiyelee fix deprecated event.returnValue in Chrome 29a9ed8
Ezequiel Event: Build. bf1c399
@zhiyelee zhiyelee update apidoc for `previous` and `next` d475607
@zhiyelee zhiyelee update and also modify the `elementByAxis` 45bb676
Ezequiel YUI, Loader: Build for the latest Gallery deployment. 12b86e9
@andrewnicols andrewnicols [io] Check whether a form still exists before resetting it
IO clears the form content on end, but if the caller removed the form soon
after it was called, this fails at a removeAttribute on part of the, now
non-existent form content.

We should check that the form exists before attempting to reset it.
0cf8d82
Ezequiel IO: Build. aec3349
@tripp tripp Merge branch 'live-docs' into dev-master a6c3f9c
@tripp tripp Build files for dom and node. ab816c6
@rgrove rgrove Fix node-scroll-info inaccuracy in Chrome for Android. Fixes #1483 5a1d022
@rgrove rgrove Build node-scroll-info. 183c08d
@ekashida ekashida YUI and Loader build for latest Gallery build b53653c
@ogennadi ogennadi Included missing periods 4ab4455
@zhiyelee zhiyelee update event HISTORY.md to refer #1460 f68010a
@juandopazo juandopazo Add Bower to devDependencies list 789bc25
@okuryu okuryu Fix a bug with setStyle() cannot set an opacity to 1
This problem occurs when you try to set an opacity to 1 using node.setStyle()
method on IE. It has adapted to change an opacity only if less than 1, but we
should change an opacity, even if it passed 1. Fix #1469.
95c52dc
@okuryu okuryu Update the change log 21cb61c
@okuryu okuryu Build DOM 00238b5
@zhiyelee zhiyelee add link url fe586a8
@okuryu okuryu Merge branch 'fix1363' into dev-master 350b397
Joe Covalesky fix FF contenteditable backspace bug. ca88c78
Clarence Leung Merge branch 'release-3.14.1' into live-docs c0406bd
Clarence Leung Merge branch 'live-docs' into dev-master 3a20508
Clarence Leung Seeding HISTORY.md files for next release c23e81e
Clarence Leung Bump metadata JSON files to 3.14.2-pre ec40f5a
Clarence Leung Re-add DOM history change by @okuryu
This was originally overwritten when merging in v3.14.1.
6f2947d
Ezequiel Rodriguez Merge remote-tracking branch 'zhiyelee/dev-master' into dev-master 259e918
Ezequiel Rodriguez Event Gestures: Addition of IE 11 to `should ignore` condition. 71c2fdd
@juandopazo juandopazo [node-view] Use 'hidden' as the attribute's value
Even though the attribute's effect gets activated for any value of the
attribute, this way it's easier for anyone looking at the DOM to figure
out what the visibility of the node is.
a59a652
@juandopazo juandopazo [node-view] Document node._isHidden 7286af2
@ekashida ekashida YUI and Loader build for latest Gallery build c364a1e
@juandopazo juandopazo Merge branch 'node-hidden' into dev-master 53195bf
Ezequiel Rodriguez Editor: IE 11 no longer supports `document.selection`, in favor of `w…
…indow.getSelection`.
fac3fa0
Ezequiel Rodriguez Editor: Build. ae5f322
@juandopazo juandopazo [event-custom] Document defaultTargetOnly flag f20a7ba
@juandopazo juandopazo Merge branch 'live-docs' into dev-master 0ecf4cd
Clarence Leung Remove `X-Requested-With` info in XDR example
This is no longer necessary as using `xdr: native` will remove
all custom headers for you by default.
fd40ad7
@smikes smikes fix typo in docs ba939e1
@juandopazo juandopazo Merge branch 'dd-typo' of github.com:smikes/yui3 into smikes-dd-typo c49d2f9
@juandopazo juandopazo Merge branch 'live-docs' into dev-master cea53cb
@juandopazo juandopazo [docs] Replace variants of Number 73fd901
@juandopazo juandopazo [docs] Replace variants of undefined 751adfb
@juandopazo juandopazo [docs] Replace variants of HTMLElement dc0713e
@juandopazo juandopazo [docs] Replace variants of Function deb0f2a
@juandopazo juandopazo [docs] Replace variants of CustomEvent 141ec8d
@juandopazo juandopazo [docs] Replace variants of EventFacade ed95a74
@juandopazo juandopazo [docs] Remove return types from chainable methods dedc570
@juandopazo juandopazo [docs] Remove unnecessary 'Y.' from type docs 80ed47c
@juandopazo juandopazo [docs] Replace HTML types with String 1d7e0f7
@juandopazo juandopazo [docs] Rename XMLDoc to correct class name 36d1acf
@juandopazo juandopazo [docs] Replace {Variant} with {Any} 1a8b5ac
@juandopazo juandopazo [docs] RangeObject is Range in the DOM c08bb5e
@juandopazo juandopazo [docs] Replace {config} with {Object} 4f5749c
@juandopazo juandopazo [docs] Provide extra type information instead of {Array} 24558b0
@juandopazo juandopazo [event-tap] Add W3C pointer event support. Fixes #1377
IE11 changed the `type` of pointer event objects from 'MSPointerDown' to
'pointerdown' to comply with their proposed W3C standard. Firefox
Nightly also supports W3C Pointer events with a
dom.w3c_pointer_events.enabled flag
6a54870
@juandopazo juandopazo [event-tap] Use window.PointerEvent for feature testing 0c7c536
@juandopazo juandopazo [docs] Fix typo in ModelSync.REST._onSyncIOStart 99e5f59
@juandopazo juandopazo [docs] Remove extra + from ClassNameManager.getClassName 58c634b
@juandopazo juandopazo [docs] Change type 'HTML template' to String 58866a6
@juandopazo juandopazo [docs] Use correct type syntax in DDMBase._setDragMode fd14e31
@juandopazo juandopazo [docs] Remove @return {Self} when there's @chainable 1086342
@juandopazo juandopazo [docs] Categorize COMMANDS as a class 047d3a1
@juandopazo juandopazo [docs] Document widget.move() correctly 8abe360
@juandopazo juandopazo [docs] Fix typo in drawTick() 8a40238
@juandopazo juandopazo [docs] Correctly override COMMANDS.createLink 2fd8a5a
@juandopazo juandopazo [docs] Fix various misnamed parameters 9eec483
@juandopazo juandopazo [docs Fix various parameter types 13cbfc2
@juandopazo juandopazo [docs] Remove all @return {undefined} a14ade3
@juandopazo juandopazo [docs] Undo renaming of Y.Object() as a function 89c53f4
@juandopazo juandopazo [timers] Add performance tests for Y.soon() e8f33de
@juandopazo juandopazo [docs] Set getClassName() parameters to variadic adc4d9b
@juandopazo juandopazo [docs] Normalize simulateKeyEvent optional parameters 46900a4
@juandopazo juandopazo [docs] Fix some typos 940c37d
@juandopazo juandopazo [promise] Mock Github API calls in doc examples 84454ca
@juandopazo juandopazo [promise] Mock API use in simple example f7b80ca
@juandopazo juandopazo [promise] Expose the mock functionality as error handling bfb7303

Clarence Leung and others added some commits Jan 21, 2014

Clarence Leung Merge remote-tracking branch 'andrewnicols/693' into dev-master 5367c6a
Clarence Leung [dd-gestures] Build 0809bee
Clarence Leung [dd-gestures] Update HISTORY.md with #1557 783be82
Ezequiel Rodriguez [DD] : Creation of YUI config. 4caf9db
Ezequiel Rodriguez [DD] : Addition of YUI config to example pages. 94630f2
Ezequiel Rodriguez [DD] : Mock YQL module. 903874f
Ezequiel Rodriguez [DD] : Removal of defunct Wired feed. cb0e8fa
Ezequiel Rodriguez Merge branch 'datatable-mock' into dev-master 3d6fa98
Ezequiel Rodriguez [DataSource] : Mock DataSource-IO's example. 02c1cac
Eugene Kashida YUI and Loader build for latest Gallery build 7d669db
@hacklschorsch hacklschorsch [dd-ddm] : Fix #1492 regression "Drop Based Coding"
At ~ 3.7.3 a regression was introduced by 1a55a78 that broke
"Drop Based Coding" by using Array.each() for otherDrops which
is an Object Literal.
ca13211
@hacklschorsch hacklschorsch [dd-ddm] : Fix #1492 (build files) 8677721
Clarence Leung Merge remote-tracking branch 'ogennadi/patch-7' into dev-master 7b841e9
Clarence Leung [node-base] Build, no min-changes 19d5905
@okuryu okuryu Merge branch 'rm-modules-list' into live-docs b468430
@adinardi adinardi Fix Amazon Silk detection in Y.UA.
Amazon updated the UA string as specified here:
http://docs.aws.amazon.com/silk/latest/developerguide/user-agent.html
7badc1a
@jconniff jconniff fixes #1431: Removing 'scoped from 'style' blocks in all library exam…
…ple .mustache files
6dabea9
@rgrove rgrove Build yui. 65f0bff
@rgrove rgrove Update yui history. bc9230a
@rgrove rgrove Add missing link. 6c07c86
@hacklschorsch hacklschorsch [dd-ddm] : Fix #1492 regression "Drop Based Coding"
Include @okuryu's suggestions. Thanks!
9b5f1c1
@hacklschorsch hacklschorsch [dd-ddm] : Fix #1492 (build files) b7a6d1a
@customcommander customcommander [docs] Document usage of username/password in Y.io config. Fix #1572 ed10ce3
@jconniff jconniff merging dev-master into local branch 2c40dda
@tripp tripp YUI and Loader build for latest Gallery build f3997c6
@okuryu okuryu Merge remote-tracking branch 'customcommander/docs-io-auth' into live…
…-docs
2c5431d
@jconniff jconniff Finishing the removal of scoped from style blocks started in pr#1577 4037c80
@customcommander customcommander [docs] Fix typo in docs for event-custom 905b888
Ezequiel Rodriguez Merge branch 'dd-mock' into dev-master 28c4846
@okuryu okuryu Merge remote-tracking branch 'hacklschorsch/bug_1492' into dev-master e16c249
@okuryu okuryu [dd] Update the history 2d7a09d
@juandopazo juandopazo [core] Fix value of `this` inside ES6 module definitions c419347
Ezequiel Rodriguez [Loader] : Addition of `calculate` to performance tests. b1cabc5
Ezequiel Rodriguez [Loader] : Refactor of performance tests. 3d336a7
Ezequiel Rodriguez [Loader] : Update five tests. 14e151a
Ezequiel Rodriguez [Loader] : Rewrite of `_sort`. c21a213
@okuryu okuryu [node] Remove Node and NodeList methods duplicate comments
getAttribute() and setAttribute() methods of Node and NodeList
definition by comments for API Docs are duplicated. Fix #1604.
ad84e30
@okuryu okuryu Merge branch 'fix1604' into live-docs 84c62ac
@okuryu okuryu [node] Build
min files is no changes.
a0f8284
@juandopazo juandopazo Merge branch 'es6-context' into dev-master d266a9a
@okuryu okuryu [dom] Normalize setting a node value to null
When set a node value to `null`, then a node value returns `"null"` as string
on the legacy IE (IE <= 9). A node value returns an empty string on the modern
browsers (Chrome, Firefox, IE >= 10). This change is to normalize the results
of setting a node value to `null` on any browsers. Fix #1603.
408cb79
Ezequiel Rodriguez [YUI, Loader] : Build. 0fad765
Ezequiel Rodriguez [History] : Remove `history-hash-ie` from roll up. b95915d
@andrewnicols andrewnicols [Log] Provide a default log category for Y.log calls
Set a default log category of info if no category was specified, or the
category specified is not in the list of valid categories.
dacc8fe
Joe Covalesky tweaks per https://github.com/yui/yui3/pull/1502/files#r8857828 f8f8126
Joe Covalesky tweaks per https://github.com/yui/yui3/pull/1502/files#r8852815 3dfd41f
@okuryu okuryu [tabview] Fix missing the mention of module as tabveiw
Fix #1255.
14889c4
@okuryu okuryu Merge branch 'fix1255' into live-docs 56b101d
@okuryu okuryu [tabview] Build
min files is no change.
d67f8b1
@juandopazo juandopazo [core] Add tests for `throwFail` branch
This commit adds tests for the value of `this` inside modules when using
`throwFail = true`. This is because throwFail is actually branching the
attachment of the module. See
https://github.com/yui/yui3/blob/dev-master/src/yui/js/yui.js#L801-L810

Also adding missing test for legacy modules.
63e0ca1
@okuryu okuryu [node] Remove the obsolete name param of toggleView method for API docs
Fix #1478.
0e170c6
@solmsted solmsted Update dataschema-text.mustache
Remove the extra closing parenthesis that causes a syntax error.
813b877
@okuryu okuryu Merge remote-tracking branch 'solmsted/patch-1' into live-docs efb9f69
@drjayvee drjayvee Fixed node-view documentation
The section "Checking visibility" did not reflect the change made in #895
38bc339
@juandopazo juandopazo Merge branch 'live-docs' into dev-master df9f2f2
@juandopazo juandopazo Build changes 3e0a26a
Ezequiel Rodriguez Merge remote-tracking branch 'joecomotion/editor-para' into dev-master 3038955
Ezequiel Rodriguez [Editor] : Build. feaa30f
@jafl jafl use visibility:inherit to allow overlays to be hidden 517a35b
@jafl jafl update change log 8506424
Clarence Leung [docs] Fix trailing comma in GH Contributors mocks 60d5e20
Ezequiel Rodriguez Merge branch 'app-history-fix' into dev-master 9f50d69
Ezequiel Rodriguez [YUI, Loader]: Build. da60284
Contributor

ezequiel commented on 60d5e20 Feb 11, 2014

Nice catch.

Clarence Leung and others added some commits Feb 11, 2014

Clarence Leung [docs] Fix trailing comma in XDR mocks cda7c4c
Ezequiel Rodriguez Merge branch '_sort-rewrite' into dev-master 93892e0
Ezequiel Rodriguez [YUI, Loader]: Build. 1390eb5
@tripp tripp Fixes #1632 a8d2c56
@okuryu okuryu Merge branch 'fix1603' into dev-master 9789653
@okuryu okuryu [dom] Build
min files are no change.
39bba06
@okuryu okuryu [node] Remove the obsolete name param of toggleView method for API docs
Fix #1478.
0755cb9
@okuryu okuryu Merge branch 'fix1478' into live-docs 3ef049a
@okuryu okuryu [node] Build
min files are no change.
2612fd6
@okuryu okuryu Merge branch 'live-docs' into dev-master
Conflicts:
	build/node-style/node-style-coverage.js
eb959c2
Clarence Leung [docs] Increase wait time for GH contributors test f9abc81
@tripp tripp Merge branch 'issue1565' into dev-master 9ef1fed
@tripp tripp Grahics build files. 6e14f52
@reid reid Add YUI coverageOptions for Yeti.
 - Do not instrument files in Yeti.
 - Use ?filter=coverage query to trigger loading instrumented
   files in tests.

Allows for `yeti -c` to use these options without specifying
them on the command line.
6c3933d
Clarence Leung [docs] Add mock data to JSONP Gallery example eee1ba2
Clarence Leung [docs] Add mock data to JSONP GitHub example ca76b20
Clarence Leung Merge branch 'mock-jsonp-examples' into dev-master 9c138b1
@tripp tripp Merge branch 'issue1632' into dev-master ca6b4e2
@tripp tripp Build files for axis-category-base. 5a487b4
@tripp tripp Merge remote-tracking branch 'upstream/dev-master' into dev-master 5ec38ec
Clarence Leung [docs] Mock data for AutoComplete YQL example f69fee5
Clarence Leung [docs] Mock data for AutoComplete Geocode example f1afe9f
Clarence Leung Merge remote-tracking branch 'andrewnicols/ylog-missing-categories' i…
…nto dev-master
d383568
Clarence Leung [core] Update HISTORY.md b722e99
Clarence Leung YUI and Loader build for latest Gallery build ce88c05
@okuryu okuryu Merge remote-tracking branch 'jafl/calendar-visibility' into dev-master d9d26b3
@okuryu okuryu [calendar] Build
min files are no change.
6f3852d
@okuryu okuryu [calendar] Update the history bd79eac
Clarence Leung [docs] Mock AutoComplete Flickr example 4de39e8
@goodforenergy goodforenergy Removing unnecessary source attribute added in 6eaf842. Including the…
… source attribute can cause an extra request to be made to the current page URL when the iFrame is included on the page. See issue #1622.
92f25f1

Please see #1716

@ezequiel ezequiel merged commit 92f25f1 into yui:dev-master Mar 26, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

ezequiel commented Mar 26, 2014

Thanks.

Before anyone freaks out, all the seemingly unrelated commits did not get merged in. Only the change in orionhealth/yui3@92f25f1 did.

Contributor

rgrove commented on src/yui/js/yui-log.js in dacc8fe Apr 2, 2014

@andrewnicols This line breaks log messages from YUI Test.

Prior to this commit, Y.log() allowed arbitrary log levels, which was useful in places like YUI Test where we want to log messages with level 'pass' to indicate passing tests, 'fail' to indicate failing tests, etc. It's also useful in developer-land for logging and filtering based on custom criteria.

As of this commit, test results from YUI Test are all logged as 'info', which means test failures are not properly reported in the browser test console, grover, or yeti. What was the reason for restricting log categories to a hard-coded set of categories?

Contributor

triptych replied Apr 2, 2014

This looks like a release blocker for 3.16.0 - we need to either fix or revert this commit.

Contributor

triptych replied Apr 2, 2014

Created an issue for this : #1745

unkillbob deleted the orionhealth:io-upload-iframe-src branch May 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment