Skip to content

[dom] Optimize dom-style.js and dom-style-ie.js #1683

Merged
merged 2 commits into from Mar 11, 2014

3 participants

@okuryu
YUI Library member
okuryu commented Mar 6, 2014

There were code lines better to fix some good and some unnecessary variables. I expect to get the one or more efficiency improvement by this change.

okuryu added some commits Mar 3, 2014
@okuryu okuryu [dom] Optimize dom-style.js
* Remove unnecessary anonymous function, unused variables.
* Use "Number()" instead of "new Number()".
889e9bb
@okuryu okuryu [dom] Optimize dom-style-ie.js
* Remove unnecessary anonymous function, unused variables.
* Use "===" instead of "==".
9856685
@demonkoryu demonkoryu commented on the diff Mar 6, 2014
src/dom/js/dom-style-ie.js
@@ -1,4 +1,3 @@
-(function(Y) {
@demonkoryu
demonkoryu added a note Mar 6, 2014

I'm pretty sure this is intended to avoid creating global variables.

@okuryu
YUI Library member
okuryu added a note Mar 6, 2014

I think this is unnecessary because our source code will be wrapped by YUI.add() method after building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@okuryu okuryu added the 3 - Review label Mar 6, 2014
@okuryu okuryu added this to the Sprint 13 milestone Mar 6, 2014
@okuryu okuryu self-assigned this Mar 6, 2014
@ezequiel
YUI Library member
ezequiel commented Mar 8, 2014

I like the clean up. 👍

@okuryu
YUI Library member
okuryu commented Mar 11, 2014

Merged.

@ezequiel Thanks for your review!

@okuryu okuryu merged commit 9856685 into yui:dev-master Mar 11, 2014

1 check passed

Details default The Travis CI build passed
@okuryu okuryu deleted the okuryu:optimize-dom-style branch Mar 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.