[dom] Move out of color-base module #1709

Merged
merged 1 commit into from Apr 10, 2014

Projects

None yet

3 participants

@okuryu
Member
okuryu commented Mar 17, 2014

Currently, the dom-style module depends on color-base module only for falling back to calculate computed style on legacy Opera (<= 12), but the latest Opera (15+) is almost the same Chrome (Y.UA.webkit returns truth actually). Many core modules are depending the dom-style module, I expect that many YUI modules and applications will benefit to faster from more than a little by this change. I also hope that this resolves #1621.

I'd like to push this into the dev-3.x branch because this changes are across some module's dependencies. And I will rebuild anim, dom, loader, graphics modules and update the HISTORY.md for dom module when this has been merged.

Note: The dom-style-ie module will still depends on the color-base module for the legacy IE (<= 8.0).

@okuryu okuryu [dom] Move out of color-base module
Currently, the `dom-style` module depends on `color-base` module only for
falling back to calculate computed style on legacy Opera (<= 12), but the
latest Opera (15+) is almost the same Chrome (`Y.UA.webkit` returns truth
actually). Many core modules are depending the `dom-style` module, I expect
that many YUI modules and applications will benefit to faster from more
than a little by this change. I also hope that this resolves #1621.
b169713
@yahoocla

CLA is valid!

@okuryu okuryu self-assigned this Mar 20, 2014
@okuryu okuryu added this to the Sprint 13 milestone Mar 20, 2014
@okuryu okuryu added the 3 - Review label Mar 20, 2014
@ezequiel
Member
ezequiel commented Apr 9, 2014

👍

A few of us were wondering the same thing. Let's get this in.

@okuryu
Member
okuryu commented Apr 10, 2014

@ezequiel Thanks. Merged.

@okuryu okuryu merged commit b169713 into yui:dev-3.x Apr 10, 2014

1 check passed

default The Travis CI build passed
Details
@okuryu okuryu removed the 3 - Review label Apr 10, 2014
@okuryu okuryu deleted the okuryu:move-out-color branch Apr 10, 2014
@okuryu okuryu removed this from the Sprint 13 milestone May 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment