New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1731: Y.Calendar.selectDates fails when passed the maximumDate with... #1752

Merged
merged 1 commit into from Apr 16, 2014

Conversation

Projects
None yet
3 participants
@mairatma
Contributor

mairatma commented Apr 3, 2014

... minutes/seconds

Fixing the issue explained in #1731, which causes selectDates to fail when the user passes the maximumDate with minutes or seconds to it. The calendar code is already resetting the hours part of the date's time, but this diff resets everything to make sure that date selection doesn't take the date's time into account anymore.

From what I saw in other existing pull requests it seems like people only send the /src files, so I'm also just sending those here. Let me know if I should send the respective /build files for this change as well though.

Fix #1731: Y.Calendar.selectDates fails when passed the maximumDate w…
…ith minutes/seconds

Fixing the issue explained in #1731, which causes selectDates to fail when the user passes the maximumDate with minutes or seconds to it. The calendar code is already resetting the hours part of the date's time, but this diff resets everything to make sure that date selection doesn't take the date's time into account anymore.
@yahoocla

This comment has been minimized.

yahoocla commented Apr 3, 2014

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@mairatma

This comment has been minimized.

Contributor

mairatma commented Apr 3, 2014

I've signed the CLA now

@okuryu

This comment has been minimized.

Member

okuryu commented Apr 4, 2014

@mairatma Thanks. Looks good to me.

@okuryu okuryu self-assigned this Apr 4, 2014

@okuryu

This comment has been minimized.

Member

okuryu commented Apr 11, 2014

I'd like to merge this in the next week. Until then I'm waiting any feedbacks from other reviewers.

@okuryu okuryu merged commit 87558dc into yui:dev-master Apr 16, 2014

1 of 2 checks passed

default No CLA found for this user
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@okuryu okuryu removed the 3 - Review label Apr 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment