Skip to content

Avoid processing columns if there aren't any to allow empty tables. #176

Merged
merged 1 commit into from Jan 9, 2013

5 participants

@markwoon
markwoon commented Jul 3, 2012

I'm getting "Cannot read property 'length' of undefined" error while instantiating an empty DataTable. This used to be possible in YUI 3.5.

@lsmith lsmith was assigned Jul 5, 2012
@triptych

Hi Mark! Thank you for this contribution! Sorry it's taken so long to update it. I'll be checking this in to 3.x for the next release. Once that's in, this pull request will reflect that.

@ericf
YUI Library member
ericf commented Oct 18, 2012

@triptych This should be merged into master.

@triptych

@markwoon A few checklist items for you.

Do you have a CLA filed with us (I dont see one listed)? For pull requests we need a CLA from the contributor: http://yuilibrary.com/contribute/cla/

Also do you have a testcase you can publish with this to confirm that this fixes your empty DataTable issue?

@markwoon

I just filed a CLA.

I don't have a testcase, sorry.

@triptych
triptych commented Jan 2, 2013

Ok will check this into dev-master for this upcoming release.

@triptych triptych added a commit to triptych/yui3 that referenced this pull request Jan 9, 2013
@triptych triptych Adding unit test for pr #176 1fef48b
@triptych triptych added a commit to triptych/yui3 that referenced this pull request Jan 9, 2013
@triptych triptych Build files for pr #176 e31c704
@yuibuild yuibuild merged commit 61d0c79 into yui:master Jan 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.