[loader] Fix group comboBase leaking into YUI modules #1832

Closed
wants to merge 3 commits into
from

Projects

None yet

7 participants

@juandopazo
Member

There is an issue in Loader when YUI is configured to use more than one comboBase. In some cases YUI modules like cookie may be loaded from the group's comboBase.

@juandopazo juandopazo [loader] Test group comboBase not leaking into YUI modules
7daf177
@yahoocla

CLA is valid!

@juandopazo
Member

The Travis failure seems to be due to the lack of support for "^1.1.1" versions in Node 0.8.

@caridy can I get a +1?

@triptych
Contributor

Needs a HISTORY.md entry as well please.

@ericf
Member
ericf commented May 20, 2014

LGTM

@caridy
Member
caridy commented May 20, 2014

+1

@unkillbob
Contributor

This seems to have broken the case where you're not overriding the comboBase in a group.

This line:

comboBase    = group.comboBase;

overrides the comboBase with the group.comboBase even if the group.comboBase is undefined.

This is causing modules in combo loaded groups (that don't specify their own comboBase) in our environment to be requested with the URL:

<current page url>/undefined/<group root>/path/to/module.js

Changing the aforementioned line to the following resolves the issue for us:

comboBase    = group.comboBase || comboBase;

However I don't have time to put together a full pull request + tests etc right now.

@andrewnicols andrewnicols added a commit to andrewnicols/yui3 that referenced this pull request May 22, 2014
@andrewnicols andrewnicols The group comboBase should inherit from the default if no group setti…
…ng is specified

This fixes a regression caused by #1832.
6f0060f
@andrewnicols andrewnicols added a commit to andrewnicols/yui3 that referenced this pull request May 22, 2014
@andrewnicols andrewnicols The group comboBase should inherit from the default if no group setti…
…ng is specified

This fixes a regression caused by #1832.
bfafc6c
@andrewnicols andrewnicols added a commit to andrewnicols/yui3 that referenced this pull request May 22, 2014
@andrewnicols andrewnicols The group comboBase should inherit from the default if no group setti…
…ng is specified

This fixes a regression caused by #1832.
22a3cd1
@andrewnicols andrewnicols added a commit to andrewnicols/yui3 that referenced this pull request May 22, 2014
@andrewnicols andrewnicols The group comboBase should inherit from the default if no group setti…
…ng is specified

This fixes a regression caused by #1832.
b970343
@andrewnicols andrewnicols added a commit to andrewnicols/yui3 that referenced this pull request May 22, 2014
@andrewnicols andrewnicols The group comboBase should inherit from the default if no group setti…
…ng is specified

This fixes a regression caused by #1832.
37162c4
@tripp tripp added a commit to tripp/yui3 that referenced this pull request May 22, 2014
@andrewnicols @tripp andrewnicols + tripp The group comboBase should inherit from the default if no group setti…
…ng is specified

This fixes a regression caused by #1832.
8f42a3f
@okuryu
Member
okuryu commented May 24, 2014

This PR has been cherry-picked into the master, and includes in v3.17.1.

@okuryu okuryu closed this Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment