The group comboBase should inherit from the default if no group setting is specified #1837

Closed
wants to merge 1 commit into
from

Projects

None yet

8 participants

@andrewnicols
Contributor

This fixes the regression caused by #1832.

The other options (combine, comboSep, maxURLLength) are also affected in a similar way, but these are not a regression introduced in 3.17 so I'll submit those in a separate PR.

@yahoocla

CLA is valid!

@andrewnicols
Contributor

Darn - that should have been dev-master not dev-3.x in the PR.

@juandopazo
Member

@andrewnicols thanks! I guess we'll need 3.17.2.

@juandopazo juandopazo commented on an outdated diff May 22, 2014
src/loader/HISTORY.md
@@ -1,10 +1,10 @@
YUI Loader Change History
=========================
-@VERSION@
+3.17.2
@juandopazo
juandopazo May 22, 2014 Member

The release process handles replacing @VERSION@. You should leave it.

@andrewnicols
Contributor

D'oh! I managed to not change it on another commit I did today. Brain everyhwere. New commit awaits your approval.

Thanks,

Andrew

@F21
F21 commented May 23, 2014

Thanks for fixing this! I just noticed it after upgrading to 3.17.1.

@juandopazo
Member

@andrewnicols I guess all of our brains where all over the place this week.

@tivac

inherited

@andrewnicols
Contributor

I guess it's too late for that spelling fix - oops.

@tripp
Contributor
tripp commented May 23, 2014

@andrewnicols
I can correct the typo and merge it into the branch so it will land in the 3.17.2 release.

@tripp
Contributor
tripp commented May 23, 2014
@unkillbob
Contributor

FYI I have verified the 3.17.2 RC in our environment and am happy that the issue is resolved for us :)

@tripp
Contributor
tripp commented Aug 15, 2014

This was merged into 3.17.2

@tripp tripp closed this Aug 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment