New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The group comboBase should inherit from the default if no group setting is specified #1837

Closed
wants to merge 1 commit into
base: dev-3.x
from

Conversation

Projects
None yet
8 participants
@andrewnicols
Contributor

andrewnicols commented May 22, 2014

This fixes the regression caused by #1832.

The other options (combine, comboSep, maxURLLength) are also affected in a similar way, but these are not a regression introduced in 3.17 so I'll submit those in a separate PR.

@yahoocla

This comment has been minimized.

yahoocla commented May 22, 2014

CLA is valid!

@andrewnicols

This comment has been minimized.

Contributor

andrewnicols commented May 22, 2014

Darn - that should have been dev-master not dev-3.x in the PR.

@juandopazo

This comment has been minimized.

Member

juandopazo commented May 22, 2014

@andrewnicols thanks! I guess we'll need 3.17.2.

@@ -1,10 +1,10 @@
YUI Loader Change History
=========================
@VERSION@
3.17.2

This comment has been minimized.

@juandopazo

juandopazo May 22, 2014

Member

The release process handles replacing @VERSION@. You should leave it.

The group comboBase should inherit from the default if no group setti…
…ng is specified

This fixes a regression caused by #1832.
@andrewnicols

This comment has been minimized.

Contributor

andrewnicols commented May 22, 2014

D'oh! I managed to not change it on another commit I did today. Brain everyhwere. New commit awaits your approval.

Thanks,

Andrew

@F21

This comment has been minimized.

F21 commented May 23, 2014

Thanks for fixing this! I just noticed it after upgrading to 3.17.1.

@juandopazo

This comment has been minimized.

Member

juandopazo commented May 23, 2014

@andrewnicols I guess all of our brains where all over the place this week.

@triptych

This comment has been minimized.

@tivac

This comment has been minimized.

inherited

@tivac

This comment has been minimized.

tivac commented on src/loader/HISTORY.md in 37162c4 May 23, 2014

inherited

@andrewnicols

This comment has been minimized.

Contributor

andrewnicols commented May 23, 2014

I guess it's too late for that spelling fix - oops.

@tripp

This comment has been minimized.

Contributor

tripp commented May 23, 2014

@andrewnicols
I can correct the typo and merge it into the branch so it will land in the 3.17.2 release.

@tripp

This comment has been minimized.

Contributor

tripp commented May 23, 2014

@unkillbob

This comment has been minimized.

Contributor

unkillbob commented May 26, 2014

FYI I have verified the 3.17.2 RC in our environment and am happy that the issue is resolved for us :)

@tripp

This comment has been minimized.

Contributor

tripp commented Aug 15, 2014

This was merged into 3.17.2

@tripp tripp closed this Aug 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment