Add a "contained" option on dd-scroll #189

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ghinch
Contributor
ghinch commented Jul 11, 2012

"contained" is a boolean flag that, when true, forces a dd-scroll which only scrolls in one direction to ensure that the mouse is inside the target node region along the other axis

@ghinch ghinch adding a "contained" option on dd-scroll so that single direction scr…
…olling can be limited to the region of the scroll node
cc9857e
@davglass davglass was assigned Jul 11, 2012
@davglass
Member

This looks good, can you add a test for this logic please?

@ghinch
Contributor
ghinch commented Jul 11, 2012

Sure, it'll likely be a few days before I have the time, but I'll work on it soon

@davglass
Member

Our code freeze for is on Friday for PR4, so I'll look at adding a test for this tomorrow so it doesn't miss the release.

@davglass
Member
davglass commented Sep 7, 2012

Any chance you can add tests for this and update to the lastest source?

@ghinch
Contributor
ghinch commented Sep 8, 2012

Shoot sorry Dav, I completely forgot about this, and now am in the midst of a pretty intense startup program until the start of December. I'll see if I can find time but for at least the next couple weeks I'm slammed with other code I have to get done.

@davglass
Member

Closing as "Out of date", you can resubmit a new request when you have time :)

@davglass davglass closed this Dec 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment