New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prevent-default in 'on' for document node #1955

Merged
merged 3 commits into from Sep 24, 2014

Conversation

Projects
None yet
4 participants
@tripp
Contributor

tripp commented Sep 19, 2014

I have cherry-picked @lexander 's commit from #1865, added the following:

  • unit test change
  • logic that drops the "ms" prefix when touchAction is available.

and made the request against dev-master.

lexander and others added some commits Jun 12, 2014

Don't prevent-default in 'on' for document node
The _setMsTouchActions method modifies node behavior during touch events and prevents the default response from the browser.

This will prevent pages from being scrolled in any direction if there is _any_ event listener set on the document node. For example in #1343 DDM sets an 'ongesturemove' listener on the document  in order to know when to update the locations of dragged elements. BUT, the document can no longer be scrolled via touch because of the side-effect in _setTouchActions.

This fixes #1343 and maybe #1795
@yahoocla

This comment has been minimized.

Show comment
Hide comment
@yahoocla

yahoocla Sep 19, 2014

CLA is valid!

yahoocla commented Sep 19, 2014

CLA is valid!

@tripp

This comment has been minimized.

Show comment
Hide comment
@tripp

tripp Sep 22, 2014

Contributor

@juandopazo
This addresses #1862.

@jacobrossi
This has been tested in ie10 but not yet able to test in ie11.

Contributor

tripp commented Sep 22, 2014

@juandopazo
This addresses #1862.

@jacobrossi
This has been tested in ie10 but not yet able to test in ie11.

@tripp

This comment has been minimized.

Show comment
Hide comment
@tripp

tripp Sep 23, 2014

Contributor

This has now been tested in ie11.

Contributor

tripp commented Sep 23, 2014

This has now been tested in ie11.

@tripp tripp merged commit 1213c7f into yui:dev-master Sep 24, 2014

1 of 2 checks passed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
default User has a valid Yahoo CLA
Details
@okuryu

This comment has been minimized.

Show comment
Hide comment
@okuryu

okuryu Sep 29, 2014

Member

Updated the HISTORY.md in 6419787.

Member

okuryu commented Sep 29, 2014

Updated the HISTORY.md in 6419787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment