Fix #2532594. #227

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
@apipkin
Contributor

apipkin commented Aug 22, 2012

Updates config.data to stringified config.data for future uses of the transport.

@ericf

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Aug 22, 2012

This pull request passes (merged 3835964 into 6553945).

This pull request passes (merged 3835964 into 6553945).

@ericf

This comment has been minimized.

Show comment Hide comment
@ericf

ericf Aug 22, 2012

Member

Let's try this one again :)

This is a small bug fix which should go out with the next release (3.6.1 or 3.7.0, whichever it ends up being.) That means this should be a Pull Request against the master branch.

This Pull Request contains a bunch of noise, and commits which are not part of the simple fix. Also, some of the commits are authored as apipkin@ and others as a.pipkin@

Additionally, besides the commit which has the actual code change, add a couple more commits: one for any additional unit tests which make sure we don't have regressions on this bug, and an update to IO's HISTORY.md file.

Member

ericf commented Aug 22, 2012

Let's try this one again :)

This is a small bug fix which should go out with the next release (3.6.1 or 3.7.0, whichever it ends up being.) That means this should be a Pull Request against the master branch.

This Pull Request contains a bunch of noise, and commits which are not part of the simple fix. Also, some of the commits are authored as apipkin@ and others as a.pipkin@

Additionally, besides the commit which has the actual code change, add a couple more commits: one for any additional unit tests which make sure we don't have regressions on this bug, and an update to IO's HISTORY.md file.

@ericf ericf closed this Aug 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment