Fix for #2531093 #25

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@andreas-karlsson

Made _uiAddChild always append the child's bb to the parent node which fixes #2531093
Added a test for the issue.

@ericf

This comment has been minimized.

Show comment
Hide comment
@ericf

ericf Sep 14, 2011

Member

@andreas-karlsson could you please sign the YUI CLA?

The CLA ensures that everyone who submits a work of authorship to the YUI Library is contributing work that is their own or for which they can authoritatively speak. This protects the tens of thousands of developers who use YUI in their daily work, all of whom rely on YUI's BSD license to appropriately cover their use of the library.

The CLA does not transfer title or copyright of your contributed work to Yahoo!. It merely guarantees that you approve the use of your work within YUI and by those who use the library under the terms of its license.

Thanks!

Member

ericf commented Sep 14, 2011

@andreas-karlsson could you please sign the YUI CLA?

The CLA ensures that everyone who submits a work of authorship to the YUI Library is contributing work that is their own or for which they can authoritatively speak. This protects the tens of thousands of developers who use YUI in their daily work, all of whom rely on YUI's BSD license to appropriately cover their use of the library.

The CLA does not transfer title or copyright of your contributed work to Yahoo!. It merely guarantees that you approve the use of your work within YUI and by those who use the library under the terms of its license.

Thanks!

@andreas-karlsson

This comment has been minimized.

Show comment
Hide comment
@andreas-karlsson

andreas-karlsson Sep 14, 2011

Cool, the CLA is signed.

Cool, the CLA is signed.

@sdesai

This comment has been minimized.

Show comment
Hide comment
@sdesai

sdesai Sep 15, 2011

Contributor

Hey Andreas, thanks for the pull request. There are a couple of small changes which I think are worth making:

a) Refactor the method to have a single return (just a readability/maintainability thing).

b) Add a check around the parentNode.appendChild(childBB). We don't want to append a child which already may be added to parentNode in it's correct position.

If you want, I'm happy to make these changes locally since they are pretty small, and give you credit for it, or if you want to send in another pull request I can pull it in.

Contributor

sdesai commented Sep 15, 2011

Hey Andreas, thanks for the pull request. There are a couple of small changes which I think are worth making:

a) Refactor the method to have a single return (just a readability/maintainability thing).

b) Add a check around the parentNode.appendChild(childBB). We don't want to append a child which already may be added to parentNode in it's correct position.

If you want, I'm happy to make these changes locally since they are pretty small, and give you credit for it, or if you want to send in another pull request I can pull it in.

@andreas-karlsson

This comment has been minimized.

Show comment
Hide comment
@andreas-karlsson

andreas-karlsson Sep 15, 2011

Well, you can fix it. I'm at work and have yui forked on my home computer... Thanks.

-----Original Message-----
From: Satyen Desai [mailto:reply@reply.github.com]
Sent: den 15 september 2011 03:14
To: Andreas Karlsson
Subject: Re: [yui3] Fix for #2531093 (#25)

Hey Andreas, thanks for the pull request. There are a couple of small changes which I think are worth making:

a) Refactor the method to have a single return (just a readability/maintainability thing).

b) Add a check around the parentNode.appendChild(childBB). We don't want to append a child which already may be added to parentNode in it's correct position.

If you want, I'm happy to make these changes locally since they are pretty small, and give you credit for it, or if you want to send in another pull request I can pull it in.

Reply to this email directly or view it on GitHub:
#25 (comment)

Well, you can fix it. I'm at work and have yui forked on my home computer... Thanks.

-----Original Message-----
From: Satyen Desai [mailto:reply@reply.github.com]
Sent: den 15 september 2011 03:14
To: Andreas Karlsson
Subject: Re: [yui3] Fix for #2531093 (#25)

Hey Andreas, thanks for the pull request. There are a couple of small changes which I think are worth making:

a) Refactor the method to have a single return (just a readability/maintainability thing).

b) Add a check around the parentNode.appendChild(childBB). We don't want to append a child which already may be added to parentNode in it's correct position.

If you want, I'm happy to make these changes locally since they are pretty small, and give you credit for it, or if you want to send in another pull request I can pull it in.

Reply to this email directly or view it on GitHub:
#25 (comment)

@sdesai

This comment has been minimized.

Show comment
Hide comment
@sdesai

sdesai Sep 15, 2011

Contributor

Cool. Fixed locally, with References to this pull request.

Contributor

sdesai commented Sep 15, 2011

Cool. Fixed locally, with References to this pull request.

@andreas-karlsson

This comment has been minimized.

Show comment
Hide comment
@andreas-karlsson

andreas-karlsson Sep 16, 2011

Thanks!

-----Original Message-----
From: Satyen Desai [mailto:reply@reply.github.com]
Sent: den 15 september 2011 19:27
To: Andreas Karlsson
Subject: Re: [yui3] Fix for #2531093 (#25)

Cool. Fixed locally, with References to this pull request.

Reply to this email directly or view it on GitHub:
#25 (comment)

Thanks!

-----Original Message-----
From: Satyen Desai [mailto:reply@reply.github.com]
Sent: den 15 september 2011 19:27
To: Andreas Karlsson
Subject: Re: [yui3] Fix for #2531093 (#25)

Cool. Fixed locally, with References to this pull request.

Reply to this email directly or view it on GitHub:
#25 (comment)

@rgrove rgrove closed this Oct 12, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment