Fixes #2532955 - Touch events break when YUI.Charts are used #344

merged 1 commit into from Nov 28, 2012


None yet

3 participants

stonebk commented Nov 20, 2012

"touchend" events were being captured and halted globally -- instead, only halt when the event originated from the chart

Original pull request: #341

ericf commented Nov 20, 2012

We should add a test case which verifies that events are fired when clicks or touches happen outside the chart. That way we can protect against future regressions. I'm sure @tripp will be fine with adding the test himself (and it might be easier for him to do so.)

Once the test is in, this LGTM.

tripp commented Nov 20, 2012

Yep. I'll add the test and run the suite against all the usual suspects. Barring any issues that arise, I'll merge this fix in.

@tripp tripp merged commit 4d102e3 into yui:dev-master Nov 28, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment