Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Clean up lint for calendar #349

Merged
merged 2 commits into from
+1,650 −1,642

3 participants

@apipkin

Clean up lint. Mostly whitespace fixes, some comparison operators, and two function declarations in a for loop.

@allenrabinovich - the two functions defined in the for loop were pulled out as helpers. I wasn't exactly sure the best way to comment these functions, so left them undocumented. Any insight would be helpful.

@davglass

@allenrabinovich

@apipkin - thanks for this. Here are the descriptions for the two formerly anonymous functions to add as API docs:

_renderSelectedDatesHelper is a handler for a date selection event (either a click or a keyboard selection) that adds the appropriate CSS class to a specific DOM node corresponding to the date and sets its aria-selected attribute to true.

_renderCustomRulesHelper takes in a date and determines whether that date has any rules matching it in the customRenderer; then calls the specified filterFunction if that's the case and/or disables the date if the rule is specified as a disabledDatesRule.

@davglass
Owner

:thumbsup:

@apipkin apipkin merged commit e71a076 into yui:dev-3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 26, 2012
  1. @apipkin

    Clean up lint. Mostly whitespace fixes, some comparison, and two func…

    apipkin authored
    …tion declarations in a for loop.
Commits on Nov 27, 2012
  1. @apipkin
Something went wrong with that request. Please try again.