Move Color out of DOM. #576

Merged
merged 8 commits into from May 24, 2013

Projects

None yet

3 participants

@apipkin
Contributor
apipkin commented Apr 1, 2013

Add test for 'transparent'.

Moved color.js in DOM to color-deprecated.js. There's nothing actually deprecated, just wanted to note that file was no longer in use.

Any time 'transparent' is attempted to be converted to a value, 'transparent' is returned.

@apipkin
Contributor
apipkin commented Apr 1, 2013

ping @msweeney
ping @jconniff

@msweeney
Contributor
msweeney commented Apr 1, 2013

+1

@ericf ericf commented on the diff Apr 2, 2013
src/color/js/color-base.js
@@ -318,6 +318,11 @@ Y.Color = {
@since 3.8.0
**/
_convertTo: function(clr, to) {
+
+ if (clr === 'transparent') {
+ return clr;
+ }
@ericf
ericf Apr 2, 2013 Member

So the new Y.Color will handle "transparent" correctly under its hood?

@apipkin
apipkin Apr 5, 2013 Contributor

Yes. I believe this was what @msweeney was looking for and had delivered with DOM-style color.js.

@ericf
Member
ericf commented Apr 12, 2013

What's the status of this?

@apipkin
Contributor
apipkin commented Apr 12, 2013

It's ready to go. All tests are passing on my end that I can tell. I didn't know if @msweeney wanted to weigh in on the transparency comment.

@msweeney
Contributor

The transparency bit is required for back-compat with the old version.

@ericf
Member
ericf commented Apr 30, 2013

Moved color.js in DOM to color-deprecated.js. There's nothing actually deprecated, just wanted to note that file was no longer in use.

Can we just removed this old file then?

@apipkin apipkin merged commit 4a0ce5e into yui:dev-master May 24, 2013

1 check was pending

default The Travis CI build is in progress
Details
@okuryu okuryu added a commit to okuryu/yui3 that referenced this pull request Mar 3, 2014
@okuryu okuryu [dom] Move color-base out of dom-style
This change resolves an oversight in #576. Fix #1621.
e56b04f
@okuryu okuryu added a commit to okuryu/yui3 that referenced this pull request Mar 4, 2014
@okuryu okuryu [dom] Move color-base out of dom-style
This change resolves an oversight in #576. Fix #1621.
db39c3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment