Fix glob option of .yeti.json #778

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@okuryu
Member

okuryu commented May 23, 2013

It is now not use Globstar if you are also using the Globstar, because it would match up to file under node_modules directory.

[okuryu.local](yui3@dev-3.x)$ yeti
Found 297 files to test.
  Agent connected: Chrome (26.0.1410.65) / Mac OS from 127.0.0.1
✓ Testing started on Chrome (26.0.1410.65) / Mac OS
✗ Script error: Uncaught ReferenceError: YUI is not defined
  URL: node_modules/yogi/defaults/tests/unit/index.html
  Line: 1
  User-Agent: Chrome (26.0.1410.65) / Mac OS
✗ Script error: Uncaught ReferenceError: YUI is not defined
  URL: node_modules/yogi/defaults/tests/unit/index.html
  Line: 13
  User-Agent: Chrome (26.0.1410.65) / Mac OS

So I would like to push this against dev-master branch because this doesn't affect the source code and test code.

/cc @reid

Fix `glob` option of `.yeti.json`
It is now not use Globstar if you are also using the Globstar,
because it would match up to file under `node_modules` directory.
@triptych

This comment has been minimized.

Show comment Hide comment
@triptych

triptych Jun 13, 2013

Contributor

@okuryu Looks like Travis had an issue with this PR, do you see the same test failure on your side?

https://travis-ci.org/yui/yui3/jobs/7430101#L1983

Contributor

triptych commented Jun 13, 2013

@okuryu Looks like Travis had an issue with this PR, do you see the same test failure on your side?

https://travis-ci.org/yui/yui3/jobs/7430101#L1983

@okuryu

This comment has been minimized.

Show comment Hide comment
@okuryu

okuryu Jun 14, 2013

Member

@triptych No. I think that doesn't matter my change and this Travis CI error.

Member

okuryu commented Jun 14, 2013

@triptych No. I think that doesn't matter my change and this Travis CI error.

@reid

This comment has been minimized.

Show comment Hide comment
@reid

reid Jul 25, 2013

Contributor

@okuryu Thanks for submitting this patch and sorry for the delay in our response.

It looks like the proposed change would work inside the root level directory. However, the current .yeti.json file also uses the globstar pattern to limit tests to the current component.

Perhaps we can create another .yeti.json inside of src to workaround this problem? The one inside of src can be like the original except the basedir would be .. instead of .

Contributor

reid commented Jul 25, 2013

@okuryu Thanks for submitting this patch and sorry for the delay in our response.

It looks like the proposed change would work inside the root level directory. However, the current .yeti.json file also uses the globstar pattern to limit tests to the current component.

Perhaps we can create another .yeti.json inside of src to workaround this problem? The one inside of src can be like the original except the basedir would be .. instead of .

@okuryu

This comment has been minimized.

Show comment Hide comment
@okuryu

okuryu Jul 25, 2013

Member

@reid Thank you for your response!

It looks like the proposed change would work inside the root level directory. However, the current .yeti.json file also uses the globstar pattern to limit tests to the current component.

I assumed .yeti.json is only for running Yeti inside the root of repository.

Perhaps we can create another .yeti.json inside of src to workaround this problem? The one inside of src can be like the original except the basedir would be .. instead of .

How about enhance options of .yeti.json file? I have an image of this approach has general versatility than adding another file. Like this:

{
    "basedir": ".",
    "glob": "**/tests/unit/*.html",
    "ignore": "node_modules/**"
}
Member

okuryu commented Jul 25, 2013

@reid Thank you for your response!

It looks like the proposed change would work inside the root level directory. However, the current .yeti.json file also uses the globstar pattern to limit tests to the current component.

I assumed .yeti.json is only for running Yeti inside the root of repository.

Perhaps we can create another .yeti.json inside of src to workaround this problem? The one inside of src can be like the original except the basedir would be .. instead of .

How about enhance options of .yeti.json file? I have an image of this approach has general versatility than adding another file. Like this:

{
    "basedir": ".",
    "glob": "**/tests/unit/*.html",
    "ignore": "node_modules/**"
}
@reid

This comment has been minimized.

Show comment Hide comment
@reid

reid Aug 8, 2013

Contributor

@okuryu Okay. I've opened yui/yeti#57 to get that feature into Yeti.

The use of two configuration files can be used to mitigate the problem in the meantime.

Contributor

reid commented Aug 8, 2013

@okuryu Okay. I've opened yui/yeti#57 to get that feature into Yeti.

The use of two configuration files can be used to mitigate the problem in the meantime.

@okuryu

This comment has been minimized.

Show comment Hide comment
@okuryu

okuryu Aug 8, 2013

Member

@reid Thanks for file a ticket!

Member

okuryu commented Aug 8, 2013

@reid Thanks for file a ticket!

okuryu added a commit to okuryu/yeti that referenced this pull request Aug 17, 2013

Add `ignore` configuration option
This option is intended to exclude globbed directories.
Fix #57. See also yui/yui3#778.

@okuryu okuryu referenced this pull request in yui/yeti Aug 17, 2013

Closed

Add ignore configuration option #58

@ghost ghost assigned okuryu Dec 16, 2013

@triptych

This comment has been minimized.

Show comment Hide comment
@triptych

triptych Apr 16, 2014

Contributor

@okuryu can you close this issue out if it's no longer needed given @reid 's tickets?

Contributor

triptych commented Apr 16, 2014

@okuryu can you close this issue out if it's no longer needed given @reid 's tickets?

@okuryu

This comment has been minimized.

Show comment Hide comment
@okuryu

okuryu Apr 16, 2014

Member

Yeah, this is no longer needed for me. Closing makes sense to me.

Member

okuryu commented Apr 16, 2014

Yeah, this is no longer needed for me. Closing makes sense to me.

@okuryu okuryu closed this Apr 16, 2014

@okuryu okuryu deleted the okuryu:yeti-json branch May 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment