New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #832 - transition end #880

Merged
merged 5 commits into from Sep 19, 2013

Conversation

Projects
None yet
5 participants
@Perturbatio
Copy link
Contributor

Perturbatio commented Jun 18, 2013

fixes #832
Implemented callbackOnce flag in NodeList.transtion
Added test for callbackOnce flag
fixed formatting in transition unit test

Perturbatio added some commits Jun 18, 2013

fixed issue with the test, it would always pass if any callbacks were…
… fired

changed the test to increment a counter and using a delayed wait to test

@ghost ghost assigned msweeney Jul 19, 2013

@msweeney

This comment has been minimized.

Copy link
Contributor

msweeney commented Sep 16, 2013

+1 This looks good. Thanks for the contribution!

@clarle

This comment has been minimized.

Copy link
Contributor

clarle commented Sep 19, 2013

Merged into dev-master and dev-3.x.

Thanks for the contribution, @Perturbatio!

@ybldr ybldr merged commit a293899 into yui:master Sep 19, 2013

1 check passed

default The Travis CI build passed
Details
@ericf

This comment has been minimized.

Copy link
Member

ericf commented Sep 19, 2013

Does this also fix #1204 or will that still be broken?

@clarle

This comment has been minimized.

Copy link
Contributor

clarle commented Sep 19, 2013

@ericf No, they're not really related. I'm surprised that #1204 is a problem though, that shouldn't be happening from a quick scan of the code. I'll discuss it more there.

*nevermind, it's already being worked on.

@Perturbatio Perturbatio deleted the Perturbatio:issue-832-trans-end branch Sep 19, 2013

@ericf

This comment has been minimized.

Copy link
Member

ericf commented Sep 19, 2013

@clarle yeah it's not an issue since YUI 3.9.0. So we're good on iOS 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment