Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Whitespace problem on filter:progid:DXImageTransform.Microsoft.Matrix #64

Open
tinyhill opened this Issue · 8 comments

3 participants

@tinyhill

Considering following code:

.diamond {
  filter:progid:DXImageTransform.Microsoft.Matrix(M11=0.7071067811865475, M12=-0.7071067811865477, M21=0.7071067811865477, M22=0.7071067811865475, SizingMethod='auto expand');
}

The compressed result:

.diamond{filter:progid:DXImageTransform.Microsoft.Matrix(M11=0.7071067811865475,M12=-0.7071067811865477,M21=0.7071067811865477,M22=0.7071067811865475,SizingMethod='auto expand');}

This will not work in ie6, ie7 or other ie related browsers. Here's an article about this problem: https://clientsize.wordpress.com/2011/06/15/dximagetransform-microsoft-matrix-and-the-great-minify-mystery/

@tml tml was assigned
@tml
Collaborator

@tinyhill I'd love to see a test-case for this if you have time to write one.

@khaliy

Please fix it or provide instructions how we can fix it on our way.
Thanks

@tml
Collaborator

@khaliy If you would be willing to fork the repo and submit a pull request with a test case that documents the problem and the correct fix, I'll gladly take a look at it. Unfortunately, this 'filter' property was never part of any CSS specification, and isn't even supported in IE anymore - Microsoft deprecated its use as of IE9, see http://msdn.microsoft.com/en-us/library/ms532853(v=vs.85).aspx. I'd be happy to fix the problem, but someone who understands what is and is not allowed for this outdated vendor-specific extension to CSS would need to help in that effort. :+1:

@khaliy

@tml I would make a try, unfortunately there are such cases when we have to use vendor specific rules and IE7 should also be supported.

@tml
Collaborator

@khaliy I agree, it'd be nice if we could support this. I eagerly await your pul request, and thanks!

@khaliy

@tml could you check my request please?
Thanks

@tml
Collaborator

I have proposed acceptance of the patch to the Google Group at https://groups.google.com/forum/#!topic/yuicompressor/i1D5fyIT_zg - we use a lazy consensus model, so if no one objects, I'll merge it (probably Monday morning) - thanks for putting the patch together!

@khaliy

@tml Thanks and let me know if you find any code review items

@leightonshank leightonshank referenced this issue from a commit in getloaded/yuicompressor-src
@khaliy khaliy yui/yuicompressor#64
Fix IE7 issue on matrix filters which browser accept whitespaces between Matrix parameters,
also fixing preserveTokens logic as it should happen in reverse order
d8d78b8
@tml tml was unassigned by jlecomte
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.