Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

pjax.updateTabState fails if a tab is removed in later runs #121

Closed
azakus opened this Issue · 1 comment

3 participants

@azakus

I hit this issue w.r.t events, but this could happen with any of the class tabs.

If the defaultTab of a class is set in localStorage, and there are no items for that tab, the page will through an exception on tab.addClass (because tab is null) and fail to render the tabs in the page.

Simple example

I make a class with one documented method.

/**
@class foo
@static
*/
/**
@method bar
*/

I then view the output of yuidoc in the browser for the foo class, and switch tabs to "methods"

Next, I refactor my code, and decide that I should send a bar event instead.
Now the foo class looks like this

/**
@class foo
@static
*/
/**
@event bar
*/

When I look at the foo class in the browser, defaultTab is set to a tab that no longer exists, and errors setting the tab.

@davglass
Owner
@ericf ericf closed this in 0dcb97a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.